New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outdated Modules/Setup warning is invisible #76610
Comments
The devguide advise to run
is invisible (gets on screen first, and get kicked real quick by the compilation lines). This got me once, and I'm not alone: https://bugs.python.org/issue32335 (And I suspect we're more than just two). I propose to make this stop the compilation, proposing two cases:
Something like: $ make
|
I'd really like it if we could get rid of the Setup/Setup.dist thing. It's a distraction to have to type |
On Dec 26, 2017, at 18:17, Antoine Pitrou report@bugs.python.org wrote:
+1 - do you have any thoughts on that? |
Antoine: I may take a look at this too. Still, stopping in the Makefile looks a first trivial step toward not being screwed by it, removing it looks non trivial, will raise discussions, let's make it another issue? |
I think the current scheme may have been useful at a time where DVCS didn't exist. You would maintain an unversioned copy of Modules/Setup.dist in your work-tree. Nowadays you can fork a github repo and maintain your own branch with changes to a tracked file. I don't think Modules/Setup deserves special treatment compared to, say, setup.py or Makefile.pre.in. |
Make sense for me, Xavier, would this fit your usage? |
On 27.12.2017 00:24, Antoine Pitrou wrote:
The file is mostly meant for people using tar balls rather than The same could be had by having Makefile.pre.in generate Setup.dist |
It seems that it is possible to keep the current behavior for those that want to customize the configuration of Modules/Setup.dist (knowing that they can just use Modules/Setup.local if they are only doing additions to the Setup configuration) and at the same time get rid of these warnings for those that never change Modules/Setup.dist. This could be done this way:
If this proposal is acceptable then it should be implemented in another issue, I think. |
Discussion about further simplifications goes here: https://bugs.python.org/issue32430 |
I'm ok with turning the warning into an error. Does anyone object here? |
Please don't convert the warning to an error. Usually, I ignore the warning and "make" produces a working ./python binary anyway. It's common that I get the warning when using git bisect, since it updates Modules/Setup.dist. If you want to make it an error, I would prefer to have an option to "ignore the warning", like always copy Modules/Setup.dist to Modules/Setup (if it's detected as outdated). I like Xavier's proposal (msg309078): only create Modules/Setup if you want to customize it, otherwise use Modules/Setup.dist. I *never* modified Modules/Setup, I don't even know its purpose, whereas it bugs me frequently with it's annoying warning... It seems like I would prefer to see bpo-32430 fixed. |
Fixed in 961d54c. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: