Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

siphash shouldn't byte swap the keys #76441

Closed
benjaminp opened this issue Dec 9, 2017 · 3 comments
Closed

siphash shouldn't byte swap the keys #76441

benjaminp opened this issue Dec 9, 2017 · 3 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@benjaminp
Copy link
Contributor

BPO 32260
Nosy @benjaminp
PRs
  • bpo-32260: don't byte swap siphash keys #4771
  • byte swap the raw hash secrets (more bpo-32260) #4773
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-12-09.22:06:40.360>
created_at = <Date 2017-12-09.19:02:55.507>
labels = ['interpreter-core', '3.8', 'type-bug', '3.7']
title = "siphash shouldn't byte swap the keys"
updated_at = <Date 2017-12-09.22:06:40.359>
user = 'https://github.com/benjaminp'

    bugs.python.org fields:

    activity = <Date 2017-12-09.22:06:40.359>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2017-12-09.22:06:40.360>
closer = 'benjamin.peterson'
components = ['Interpreter Core']
creation = <Date 2017-12-09.19:02:55.507>
creator = 'benjamin.peterson'
dependencies = []
files = []
hgrepos = []
issue_num = 32260
keywords = ['patch']
message_count = 3.0
messages = ['307910', '307913', '307915']
nosy_count = 1.0
nosy_names = ['benjamin.peterson']
pr_nums = ['4771', '4773']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue32260'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @benjaminp
    Copy link
    Contributor Author

    Reference siphash takes the keys as a bytes, so it makes sense to byte swap when reifying the keys as 64-bit integers. However, Python's modified siphash takes host integers in to start with.

    @benjaminp benjaminp added 3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Dec 9, 2017
    @benjaminp
    Copy link
    Contributor Author

    New changeset 4e3e156 by Benjamin Peterson in branch 'master':
    bpo-32260: don't byte swap siphash keys (bpo-4771)
    4e3e156

    @benjaminp
    Copy link
    Contributor Author

    New changeset 60ed130 by Benjamin Peterson in branch 'master':
    byte swap the raw hash secrets (more bpo-32260) (bpo-4773)
    60ed130

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @benjaminp