Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add platform.android_ver() to test.pythoninfo for Android platforms #76391

Closed
xdegaye mannequin opened this issue Dec 4, 2017 · 4 comments · Fixed by #116674
Closed

Add platform.android_ver() to test.pythoninfo for Android platforms #76391

xdegaye mannequin opened this issue Dec 4, 2017 · 4 comments · Fixed by #116674
Labels
3.7 (EOL) end of life build The build process and cross-build OS-android type-feature A feature request or enhancement

Comments

@xdegaye
Copy link
Mannequin

xdegaye mannequin commented Dec 4, 2017

BPO 32210
Nosy @vstinner, @xdegaye, @moreati
Dependencies
  • bpo-26855: android: add platform.android_ver()
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2017-12-04.09:39:35.000>
labels = ['type-feature', '3.7', 'build']
title = 'Add platform.android_ver()  to test.pythoninfo for Android platforms'
updated_at = <Date 2017-12-05.16:34:30.711>
user = 'https://github.com/xdegaye'

    bugs.python.org fields:

    activity = <Date 2017-12-05.16:34:30.711>
actor = 'xdegaye'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Cross-Build']
creation = <Date 2017-12-04.09:39:35.000>
creator = 'xdegaye'
dependencies = ['26855']
files = []
hgrepos = []
issue_num = 32210
keywords = []
message_count = 4.0
messages = ['307544', '307581', '307602', '307657']
nosy_count = 3.0
nosy_names = ['vstinner', 'xdegaye', 'Alex.Willmer']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue32210'
versions = ['Python 3.7']
    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Dec 4, 2017

    • The NDK version can be obtained by parsing the file $ANDROID_NDK_ROOT/source.properties.
    • The versions of the SDK build-tools, emulator and platform-tools packages as well as those of the system images can be obtained by parsing the output of "$ANDROID_SDK_ROOT/tools/bin/sdkmanager --list".

    @xdegaye xdegaye mannequin added 3.7 (EOL) end of life build The build process and cross-build type-feature A feature request or enhancement labels Dec 4, 2017
    @vstinner
    Copy link
    Member

    vstinner commented Dec 4, 2017

    Maybe add a collect_android() function which would exit early if sys.getandroidapilevel() doesn't exist?

    • The NDK version can be obtained by parsing the file $ANDROID_NDK_ROOT/source.properties.
    • The versions of the SDK build-tools, emulator and platform-tools packages as well as those of the system images can be obtained by parsing the output of "$ANDROID_SDK_ROOT/tools/bin/sdkmanager --list".

    You are free to add whatever you want/need, but just try to handle properly errors to collect other info even if these data cannot be read.

    @vstinner
    Copy link
    Member

    vstinner commented Dec 4, 2017

    Oh, I forgot that pythoninfo already has:

    call_func(info_add, 'sys.androidapilevel', sys, 'getandroidapilevel')

    Well, that's the *build time* API level, not the most useful one, but still useful.

    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Dec 5, 2017

    The NDK version may be printed by the pythoninfo make target before test.pythoninfo is run on Android.

    platform.android_ver() (not yet implemented, see bpo-26855) must be added to collect_sys() in test.pythoninfo.

    @xdegaye xdegaye mannequin changed the title Add the versions of the Android SDK and NDK to test.pythoninfo Add platform.android_ver() to test.pythoninfo for Android platforms Dec 5, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @mhsmith mhsmith mentioned this issue Jan 15, 2024
    Closed
    This was referenced Mar 11, 2024
    Open
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life build The build process and cross-build OS-android type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging a pull request may close this issue.

    gh-71042: Add platform.android_ver mhsmith/cpython
    2 participants
    @vstinner @encukou