Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os.statvfs lacks f_fsid #76324

Closed
giuseppe mannequin opened this issue Nov 26, 2017 · 5 comments
Closed

os.statvfs lacks f_fsid #76324

giuseppe mannequin opened this issue Nov 26, 2017 · 5 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@giuseppe
Copy link
Mannequin

giuseppe mannequin commented Nov 26, 2017

BPO 32143
Nosy @freddrake, @vadmium, @giuseppe
PRs
  • bpo-32143: add f_fsid to os.statvfs() #4571
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-12-14.23:23:55.991>
created_at = <Date 2017-11-26.16:17:33.547>
labels = ['type-feature', 'library']
title = 'os.statvfs lacks f_fsid'
updated_at = <Date 2017-12-14.23:23:55.989>
user = 'https://github.com/giuseppe'

    bugs.python.org fields:

    activity = <Date 2017-12-14.23:23:55.989>
actor = 'fdrake'
assignee = 'none'
closed = True
closed_date = <Date 2017-12-14.23:23:55.991>
closer = 'fdrake'
components = ['Library (Lib)']
creation = <Date 2017-11-26.16:17:33.547>
creator = 'gscrivano'
dependencies = []
files = []
hgrepos = []
issue_num = 32143
keywords = ['patch']
message_count = 5.0
messages = ['307007', '307021', '308292', '308342', '308344']
nosy_count = 3.0
nosy_names = ['fdrake', 'martin.panter', 'gscrivano']
pr_nums = ['4571']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue32143'
versions = []
    @giuseppe
    Copy link
    Mannequin Author

    giuseppe mannequin commented Nov 26, 2017

    the os.statvfs() function doesn't return f_fsid. The POSIX definition of statvfs() has f_fsid:

    http://pubs.opengroup.org/onlinepubs/009604599/basedefs/sys/statvfs.h.html

    @giuseppe giuseppe mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Nov 26, 2017
    @vadmium
    Copy link
    Member

    vadmium commented Nov 26, 2017

    The doc string for the result object, and the main Python 2 documentation, both say that the result is a 10-tuple. So perhaps any new field should only be an attribute, and the tuple should stay the same size, to maintain compatibility. This was done in other cases, e.g. struct_time and stat_result.

    @freddrake
    Copy link
    Member

    I think Giuseppe's patch is good, but there's a Windows failure on AppVeyor, so I'm a little wary. It doesn't look related, but I haven't looked at Python on Windows since... 2001, maybe?

    @freddrake
    Copy link
    Member

    New changeset 96a5e50 by Fred Drake (Giuseppe Scrivano) in branch 'master':
    bpo-32143: add f_fsid to os.statvfs() (bpo-4571)
    96a5e50

    @freddrake
    Copy link
    Member

    This has landed on master and will be part of Python 3.7.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @freddrake @vadmium