Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile error when converting selectmodule to AC due to missing #define-s #76107

Closed
taleinat opened this issue Nov 2, 2017 · 5 comments
Closed

compile error when converting selectmodule to AC due to missing #define-s #76107

taleinat opened this issue Nov 2, 2017 · 5 comments
Labels
3.7 (EOL) end of life build The build process and cross-build topic-argument-clinic

Comments

@taleinat
Copy link
Contributor

taleinat commented Nov 2, 2017

BPO 31926
Nosy @vstinner, @taleinat, @larryhastings, @serhiy-storchaka
PRs
  • bpo-31926: fix missing *_METHODDEF statements by argument clinic #4230
  • [3.6] bpo-31926: fix missing *_METHODDEF statements by argument clinic (GH-4230) #4253
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-11-03.13:46:37.042>
created_at = <Date 2017-11-02.15:13:55.394>
labels = ['build', '3.7', 'expert-argument-clinic']
title = 'compile error when converting selectmodule to AC due to missing #define-s'
updated_at = <Date 2017-11-03.13:46:37.041>
user = 'https://github.com/taleinat'

    bugs.python.org fields:

    activity = <Date 2017-11-03.13:46:37.041>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2017-11-03.13:46:37.042>
closer = 'vstinner'
components = ['Argument Clinic']
creation = <Date 2017-11-02.15:13:55.394>
creator = 'taleinat'
dependencies = []
files = []
hgrepos = []
issue_num = 31926
keywords = ['patch']
message_count = 5.0
messages = ['305427', '305428', '305464', '305481', '305482']
nosy_count = 4.0
nosy_names = ['vstinner', 'taleinat', 'larry', 'serhiy.storchaka']
pr_nums = ['4230', '4253']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue31926'
versions = ['Python 3.6', 'Python 3.7']
    @taleinat
    Copy link
    Contributor Author

    taleinat commented Nov 2, 2017

    I'm converting Modules/selectmodule.c.h as part of issue bpo-20182.

    After converting the code and running Tools/clinic/clinic.py, compilation is failing on Windows due to the following block *not* being generated by in the Modules/clinic/selectmodule.c.h file:

    #ifndef SELECT_POLL_METHODDEF
    #define SELECT_POLL_METHODDEF
#endif /* !defined(SELECT_POLL_METHODDEF) */

    Adding the block manually fixes the issue.

    This seems to be caused by a bug in clinic.py. Attaching PR fix a fix immediately.

    @taleinat taleinat added 3.7 (EOL) end of life topic-argument-clinic build The build process and cross-build labels Nov 2, 2017
    @taleinat
    Copy link
    Contributor Author

    taleinat commented Nov 2, 2017

    See PR 4230.

    @serhiy-storchaka
    Copy link
    Member

    New changeset 4f57409 by Serhiy Storchaka (Tal Einat) in branch 'master':
    bpo-31926: fix missing *_METHODDEF statements by argument clinic (bpo-4230)
    4f57409

    @vstinner
    Copy link
    Member

    vstinner commented Nov 3, 2017

    New changeset f8b3f6b by Victor Stinner (Tal Einat) in branch '3.6':
    [3.6] bpo-31926: fix missing *_METHODDEF statements by argument clinic (GH-4230) (bpo-4253)
    f8b3f6b

    @vstinner
    Copy link
    Member

    vstinner commented Nov 3, 2017

    Thank you Tal Einat for your bug report and your fix. It's now merged into 3.6 and master (future 3.7).

    @vstinner vstinner closed this as completed Nov 3, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life build The build process and cross-build topic-argument-clinic
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @taleinat @serhiy-storchaka