Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python/pyhash.c warning: comparison of integers of different signs #76030

Closed
xdegaye mannequin opened this issue Oct 23, 2017 · 4 comments
Closed

Python/pyhash.c warning: comparison of integers of different signs #76030

xdegaye mannequin opened this issue Oct 23, 2017 · 4 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes build The build process and cross-build easy interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@xdegaye
Copy link
Mannequin

xdegaye mannequin commented Oct 23, 2017

BPO 31849
Nosy @tiran, @methane, @xdegaye, @miss-islington
PRs
  • bpo-31849: Fix warning in pyhash.c. #6799
  • [3.7] bpo-31849: Fix warning in pyhash.c (GH-6799) #7393
  • [3.6] bpo-31849: Fix warning in pyhash.c (GH-6799) #7394
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-06-05.06:54:27.700>
created_at = <Date 2017-10-23.16:01:16.751>
labels = ['interpreter-core', '3.8', 'build', '3.7', 'easy']
title = 'Python/pyhash.c warning: comparison of integers of different signs'
updated_at = <Date 2018-06-05.06:54:27.660>
user = 'https://github.com/xdegaye'

    bugs.python.org fields:

    activity = <Date 2018-06-05.06:54:27.660>
actor = 'methane'
assignee = 'none'
closed = True
closed_date = <Date 2018-06-05.06:54:27.700>
closer = 'methane'
components = ['Interpreter Core']
creation = <Date 2017-10-23.16:01:16.751>
creator = 'xdegaye'
dependencies = []
files = []
hgrepos = []
issue_num = 31849
keywords = ['patch', 'easy (C)']
message_count = 4.0
messages = ['304816', '318642', '318678', '318687']
nosy_count = 4.0
nosy_names = ['christian.heimes', 'methane', 'xdegaye', 'miss-islington']
pr_nums = ['6799', '7393', '7394']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue31849'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Oct 23, 2017

    When built with: Android clang version 3.8.275480 (based on LLVM 3.8.275480)

    The following warning is emitted:

    ccache /pathto/android/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang -target x86_64-none-linux-androideabi -gcc-toolchain /pathto/android/android-ndk/toolchains/x86_64-4.9/prebuilt/linux-x86_64 -c -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes --sysroot=/pathto/android/android-ndk/sysroot -D__ANDROID_API__=21 -isystem /pathto/android/android-ndk/sysroot/usr/include/x86_64-linux-android -Wno-unused-value -Wno-empty-body -Qunused-arguments -Wno-nullability-completeness -Wno-parentheses-equality   -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Werror=implicit-function-declaration  -IObjects -IInclude -IPython -I. -I/pathto/src/python/master/Include -I/pathto/tmp/android-makesetup/build/python3.7-extlibs-android-21-x86_64//data/local/tmp/python/include --sysroot=/pathto/android/android-ndk/sysroot -D__ANDROID_API__=21 -isystem /pathto/android/android-ndk/sysroot/usr/include/x86_64-linux-android   -DPy_BUILD_CORE -o Python/pyhash.o /pathto/src/python/master/Python/pyhash.c
/pathto/src/python/master/Python/pyhash.c:275:11: warning: comparison of integers of different signs: 'Py_uhash_t' (aka 'unsigned long') and 'int' [-Wsign-compare]
    if (x == -1) {
        ~ ^  ~~
1 warning generated.

    @xdegaye xdegaye mannequin added 3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) build The build process and cross-build labels Oct 23, 2017
    @methane
    Copy link
    Member

    methane commented Jun 4, 2018

    New changeset a8eb585 by INADA Naoki (A. Jesse Jiryu Davis) in branch 'master':
    bpo-31849: Fix warning in pyhash.c (GH-6799)
    a8eb585

    @miss-islington
    Copy link
    Contributor

    New changeset 4251d2a by Miss Islington (bot) in branch '3.6':
    bpo-31849: Fix warning in pyhash.c (GH-6799)
    4251d2a

    @miss-islington
    Copy link
    Contributor

    New changeset 150033d by Miss Islington (bot) in branch '3.7':
    bpo-31849: Fix warning in pyhash.c (GH-6799)
    150033d

    @methane methane added the 3.8 only security fixes label Jun 5, 2018
    @methane methane closed this as completed Jun 5, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes build The build process and cross-build easy interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @methane @serhiy-storchaka @miss-islington