Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"aifc" module does not always initialize "Aifc_read._ssnd_chunk" #76029

Closed
Zero mannequin opened this issue Oct 23, 2017 · 5 comments
Closed

"aifc" module does not always initialize "Aifc_read._ssnd_chunk" #76029

Zero mannequin opened this issue Oct 23, 2017 · 5 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@Zero
Copy link
Mannequin

Zero mannequin commented Oct 23, 2017

BPO 31848
Nosy @serhiy-storchaka, @ZackerySpytz, @miss-islington
PRs
  • bpo-31848: Fix broken error handling in Aifc_read.initfp() when the SSND chunk is not found #5240
  • [3.7] bpo-31848: Fix broken error handling in Aifc_read.initfp() when the SSND chunk is not found (GH-5240) #5780
  • [2.7] bpo-31848: Fix broken error handling in Aifc_read.initfp() when the SSND chunk is not found (GH-5240) #5781
  • [3.6] bpo-31848: Fix broken error handling in Aifc_read.initfp() when the SSND chunk is not found (GH-5240) #5782
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-02-21.06:40:02.709>
    created_at = <Date 2017-10-23.13:33:00.986>
    labels = ['3.7', '3.8', 'type-bug', 'library']
    title = '"aifc" module does not always initialize "Aifc_read._ssnd_chunk"'
    updated_at = <Date 2019-10-31.14:22:13.161>
    user = 'https://bugs.python.org/Zero'

    bugs.python.org fields:

    activity = <Date 2019-10-31.14:22:13.161>
    actor = 'Zero'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-02-21.06:40:02.709>
    closer = 'serhiy.storchaka'
    components = ['Library (Lib)']
    creation = <Date 2017-10-23.13:33:00.986>
    creator = 'Zero'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 31848
    keywords = ['patch']
    message_count = 5.0
    messages = ['304804', '312434', '312439', '312441', '312472']
    nosy_count = 3.0
    nosy_names = ['serhiy.storchaka', 'ZackerySpytz', 'miss-islington']
    pr_nums = ['5240', '5780', '5781', '5782']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue31848'
    versions = ['Python 2.7', 'Python 3.6', 'Python 3.7', 'Python 3.8']

    @Zero
    Copy link
    Mannequin Author

    Zero mannequin commented Oct 23, 2017

    When Aifc_read runs initfp, it conditionally sets self._ssnd_chunk and is not guaranteed to do so. At the bottom of the method, a check is made to see if the attribute has a false value; and if so, an error is supposed to be raised. If a SSND chunk is never found, checking self._ssnd_chunk causes an attribute error to be raised similar to this:

    AttributeError: 'Aifc_read' object has no attribute '_ssnd_chunk'

    The error was found on the following distribution:

    Python 3.6.2 (v3.6.2:5fd33b5, Jul 8 2017, 04:57:36) [MSC v.1900 64 bit (AMD64)] on win32

    @Zero Zero mannequin added type-crash A hard crash of the interpreter, possibly with a core dump tests Tests in the Lib/test dir stdlib Python modules in the Lib dir labels Oct 23, 2017
    @ZackerySpytz ZackerySpytz mannequin added 3.7 (EOL) end of life 3.8 only security fixes type-bug An unexpected behavior, bug, or error and removed tests Tests in the Lib/test dir type-crash A hard crash of the interpreter, possibly with a core dump labels Feb 20, 2018
    @serhiy-storchaka
    Copy link
    Member

    New changeset 80d20b9 by Serhiy Storchaka (Zackery Spytz) in branch 'master':
    bpo-31848: Fix broken error handling in Aifc_read.initfp() when the SSND chunk is not found (bpo-5240)
    80d20b9

    @miss-islington
    Copy link
    Contributor

    New changeset 1d927d4 by Miss Islington (bot) in branch '3.7':
    bpo-31848: Fix broken error handling in Aifc_read.initfp() when the SSND chunk is not found (GH-5240)
    1d927d4

    @miss-islington
    Copy link
    Contributor

    New changeset 2b9726e by Miss Islington (bot) in branch '3.6':
    bpo-31848: Fix broken error handling in Aifc_read.initfp() when the SSND chunk is not found (GH-5240)
    2b9726e

    @serhiy-storchaka
    Copy link
    Member

    New changeset b852d8c by Serhiy Storchaka (Miss Islington (bot)) in branch '2.7':
    [2.7] bpo-31848: Fix broken error handling in Aifc_read.initfp() when the SSND chunk is not found (GH-5240) (GH-5781)
    b852d8c

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants