Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interrupts are lost during readline PyOS_InputHook processing #47430

Closed
araneidae mannequin opened this issue Jun 23, 2008 · 7 comments
Closed

Interrupts are lost during readline PyOS_InputHook processing #47430

araneidae mannequin opened this issue Jun 23, 2008 · 7 comments
Labels
extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@araneidae
Copy link
Mannequin

araneidae mannequin commented Jun 23, 2008

BPO 3180
Nosy @vstinner, @devdanzin
Files
  • input-hook.patch: Patch to implement interrupt handling input hook
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2015-01-06.11:59:27.748>
created_at = <Date 2008-06-23.16:32:22.630>
labels = ['extension-modules', 'type-feature']
title = 'Interrupts are lost during readline PyOS_InputHook processing'
updated_at = <Date 2015-01-14.02:13:56.734>
user = 'https://bugs.python.org/Araneidae'

    bugs.python.org fields:

    activity = <Date 2015-01-14.02:13:56.734>
actor = 'Michiel.de.Hoon'
assignee = 'none'
closed = True
closed_date = <Date 2015-01-06.11:59:27.748>
closer = 'vstinner'
components = ['Extension Modules']
creation = <Date 2008-06-23.16:32:22.630>
creator = 'Araneidae'
dependencies = []
files = ['10709']
hgrepos = []
issue_num = 3180
keywords = ['patch']
message_count = 7.0
messages = ['68638', '87719', '116638', '233530', '233977', '233981', '233998']
nosy_count = 4.0
nosy_names = ['vstinner', 'ajaksu2', 'Araneidae', 'Michiel.de.Hoon']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'patch review'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue3180'
versions = ['Python 2.7', 'Python 3.2']
    @araneidae
    Copy link
    Mannequin Author

    araneidae mannequin commented Jun 23, 2008

    The (undocumented!) API for PyOS_InputHook has two defects which are
    addressed in the attached patch (at least when using the readline
    module): firstly the called hook currently has to guess that input will
    come on descriptor 0; secondly, any Ctrl-C interrupts encountered during
    the processing of the input hook are lost.

    This loss of interrupts can be rather annoying. The attached patch
    addresses these problems by redefining the API to PyOS_InputHook as

        int PyOS_InputHook(int file_in);

    where file_in is the descriptor to monitor (PyOS_InputHook need not
    return until file_in is ready to read), and the return value is non-zero
    if and only if processing was interrupted.

    Testing for interruption is implemented in the HAVE_RL_CALLBACK and
    HAVE_SELECT branch of Modules/readline.c; other uses retain their
    original functionality (I believe!).

    The attached patch was prepared against
    http://svn.python.org/projects/python/trunk , current at the time of
    writing.

    @araneidae araneidae mannequin added the type-feature A feature request or enhancement label Jun 23, 2008
    @devdanzin
    Copy link
    Mannequin

    devdanzin mannequin commented May 13, 2009

    Michael,
    How does this interact with the fix from bpo-706406?

    @devdanzin devdanzin mannequin added the extension-modules C modules in the Modules dir label May 13, 2009
    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Sep 16, 2010

    I'm unsure as to whether this is a feature request or a behaviour problem, anyone? Regardless could a core dev take a look at the patch which involves changes to the API for PyOS_InputHook, see msg68638.

    @vstinner
    Copy link
    Member

    vstinner commented Jan 6, 2015

    I don't understand how to reproduce the issue, there is no unit test nor a description how to reproduce the issue.

    I'm not aware of a bug where CTRL+c is simply ignored. CTRL+c is now well handled in Python 2.7, on Linux and Windows at least.

    Since the bug is now 7 years old, I just close it as out of date, sorry.

    @vstinner vstinner closed this as completed Jan 6, 2015
    @MichieldeHoon
    Copy link
    Mannequin

    MichieldeHoon mannequin commented Jan 14, 2015

    As it happens, we just ran into the same bug.
    To reproduce this issue, run

    >> from Tkinter import *
    >> Tk()

    Then Ctrl-C will not generate a KeyboardInterrupt.

    At first glance, the solution suggested by the original poster seems good. Can this issue by reopened? I'd be happy to take over this issue report and check the patch in more detail.

    @vstinner
    Copy link
    Member

    This issue is now closed. Please open a new issue. You should mention
    your OS and the Python version at least.

    @MichieldeHoon
    Copy link
    Mannequin

    MichieldeHoon mannequin commented Jan 14, 2015

    I have opened a new bpo-23237 for this bug; please see
    http://bugs.python.org/issue23237

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    extension-modules C modules in the Modules dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vstinner