Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't mention GCC in sys.version when built with Clang #75877

Closed
benjaminp opened this issue Oct 4, 2017 · 2 comments
Closed

don't mention GCC in sys.version when built with Clang #75877

benjaminp opened this issue Oct 4, 2017 · 2 comments
Labels
3.7 (EOL) end of life build The build process and cross-build easy

Comments

@benjaminp
Copy link
Contributor

BPO 31696
Nosy @benjaminp
PRs
  • closes bpo-31696: don't mention GCC in sys.version when building with clang #3891
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-10-06.04:15:16.903>
    created_at = <Date 2017-10-04.20:56:25.072>
    labels = ['easy', 'build', '3.7']
    title = "don't mention GCC in sys.version when built with Clang"
    updated_at = <Date 2017-10-06.04:15:16.902>
    user = 'https://github.com/benjaminp'

    bugs.python.org fields:

    activity = <Date 2017-10-06.04:15:16.902>
    actor = 'benjamin.peterson'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-10-06.04:15:16.903>
    closer = 'benjamin.peterson'
    components = ['Build']
    creation = <Date 2017-10-04.20:56:25.072>
    creator = 'benjamin.peterson'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 31696
    keywords = ['patch', 'easy (C)']
    message_count = 2.0
    messages = ['303731', '303795']
    nosy_count = 1.0
    nosy_names = ['benjamin.peterson']
    pr_nums = ['3891']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue31696'
    versions = ['Python 3.7']

    @benjaminp
    Copy link
    Contributor Author

    When built with clang, Python reports that it was built with something like "GCC 4.2.1 Compatible Clang 4.0.0 (tags/RELEASE_400/rc1)". This is because clang pretends to be GCC 4.2.1 for the purposes of the __VERSION__ preprocessor macro. We should use __clang_version__ when clang is being used.

    (Possibly we should simply use the first line of "$CC --version" as the compiler version of record rather than writing preprocessor tests in getcompiler.c.)

    @benjaminp benjaminp added 3.7 (EOL) end of life build The build process and cross-build easy labels Oct 4, 2017
    @benjaminp
    Copy link
    Contributor Author

    New changeset 7faf7e5 by Benjamin Peterson in branch 'master':
    closes bpo-31696: don't mention GCC in sys.version when building with clang (bpo-3891)
    7faf7e5

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life build The build process and cross-build easy
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant