Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cPickle calls to save_string and save_unicode with unicode objects. #47414

Closed
cuerty mannequin opened this issue Jun 21, 2008 · 2 comments
Closed

cPickle calls to save_string and save_unicode with unicode objects. #47414

cuerty mannequin opened this issue Jun 21, 2008 · 2 comments
Labels
stdlib Python modules in the Lib dir

Comments

@cuerty
Copy link
Mannequin

cuerty mannequin commented Jun 21, 2008

BPO 3164
Nosy @facundobatista
Files
  • cpickle-unicode-r64448.diff: Patch to avoid the double call to save_(str
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2008-06-22.15:27:47.960>
    created_at = <Date 2008-06-21.21:02:58.906>
    labels = ['library']
    title = 'cPickle calls to save_string and save_unicode with unicode objects.'
    updated_at = <Date 2008-06-22.15:27:47.583>
    user = 'https://bugs.python.org/cuerty'

    bugs.python.org fields:

    activity = <Date 2008-06-22.15:27:47.583>
    actor = 'facundobatista'
    assignee = 'none'
    closed = True
    closed_date = <Date 2008-06-22.15:27:47.960>
    closer = 'facundobatista'
    components = ['Library (Lib)']
    creation = <Date 2008-06-21.21:02:58.906>
    creator = 'cuerty'
    dependencies = []
    files = ['10692']
    hgrepos = []
    issue_num = 3164
    keywords = ['patch']
    message_count = 2.0
    messages = ['68541', '68566']
    nosy_count = 2.0
    nosy_names = ['facundobatista', 'cuerty']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue3164'
    versions = ['Python 2.6', 'Python 3.0']

    @cuerty
    Copy link
    Mannequin Author

    cuerty mannequin commented Jun 21, 2008

    If Python trunk is compiled using Py_USING_UNICODE it'll call both,
    save_str and save_unicode for an string object.

    The patch adds a break to the case statment in case it encounters a
    unicode or str.

    @cuerty cuerty mannequin added the stdlib Python modules in the Lib dir label Jun 21, 2008
    @facundobatista
    Copy link
    Member

    Commited in 64455, thank you!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant