Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop using ranlib #75806

Closed
benjaminp opened this issue Sep 29, 2017 · 11 comments
Closed

stop using ranlib #75806

benjaminp opened this issue Sep 29, 2017 · 11 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes build The build process and cross-build

Comments

@benjaminp
Copy link
Contributor

BPO 31625
Nosy @vstinner, @benjaminp, @stratakis, @kadler
PRs
  • stop using ranlib (closes bpo-31625) #3815
  • explicitly list objects for the ar command #3824
  • [3.6] bpo-31625: Stop using ranlib #10417
  • bpo-37916: distutils: allow overriding of the RANLIB command on macOS (darwin) #15387
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-11-29.14:46:30.011>
created_at = <Date 2017-09-29.06:15:32.648>
labels = ['3.8', 'build', '3.7']
title = 'stop using ranlib'
updated_at = <Date 2019-12-09.09:40:56.912>
user = 'https://github.com/benjaminp'

    bugs.python.org fields:

    activity = <Date 2019-12-09.09:40:56.912>
actor = 'Jakub Piotr C\xc5\x82apa'
assignee = 'none'
closed = True
closed_date = <Date 2018-11-29.14:46:30.011>
closer = 'vstinner'
components = ['Build']
creation = <Date 2017-09-29.06:15:32.648>
creator = 'benjamin.peterson'
dependencies = []
files = []
hgrepos = []
issue_num = 31625
keywords = ['patch']
message_count = 11.0
messages = ['303301', '303332', '303333', '303336', '303338', '329001', '329483', '329534', '330691', '330692', '330693']
nosy_count = 4.0
nosy_names = ['vstinner', 'benjamin.peterson', 'cstratak', 'kadler']
pr_nums = ['3815', '3824', '10417', '15387']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue31625'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @benjaminp
    Copy link
    Contributor Author

    As far as I'm aware, every modern *nix's ar supports an "s" flag that removes the need to run ranlib separately on a a static library. We should just do that and stop running ranlib. That saves us some lines in configure.ac and the Makefile.

    @benjaminp benjaminp added 3.7 (EOL) end of life build The build process and cross-build labels Sep 29, 2017
    @benjaminp
    Copy link
    Contributor Author

    New changeset d15108a by Benjamin Peterson in branch 'master':
    stop using ranlib (closes bpo-31625) (bpo-3815)
    d15108a

    @vstinner
    Copy link
    Member

    Buildbots are unhappy :-( Compilation failed on:

    http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Debug%203.x/builds/962/steps/compile/logs/stdio

    http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Non-Debug%203.x/builds/964/steps/compile/logs/stdio

    @vstinner vstinner reopened this Sep 29, 2017
    @benjaminp
    Copy link
    Contributor Author

    New changeset 6fb0e4a by Benjamin Peterson in branch 'master':
    explicitly list objects for the ar command (bpo-3824)
    6fb0e4a

    @vstinner
    Copy link
    Member

    Thanks ;-)

    @stratakis
    Copy link
    Mannequin

    stratakis mannequin commented Oct 31, 2018

    Would it make sense to backport that to 3.6 as well? Currently this blocks https://bugs.python.org/issue28015 from being backported to 3.6

    @vstinner
    Copy link
    Member

    vstinner commented Nov 8, 2018

    (I reopen the issue.)

    Would it make sense to backport that to 3.6 as well? Currently this blocks https://bugs.python.org/issue28015 from being backported to 3.6

    There is a risk of regression. Does bpo-28015 fix really depend on this change?

    Benjamin wrote: "As far as I'm aware, every modern *nix's ar supports an "s" flag", but I'm not sure if Python 3.6 is only used on "modern Unix". Some people use AIX and HP-UX: does ar support "s" on these OSes?

    @vstinner vstinner reopened this Nov 8, 2018
    @kadler
    Copy link
    Mannequin

    kadler mannequin commented Nov 9, 2018

    AIX supports the -s flag: https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.cmds1/ar.htm#ar__row-d3e27561

    @vstinner
    Copy link
    Member

    New changeset e1b2103 by Victor Stinner (stratakis) in branch '3.6':
    [3.6] bpo-31625: Stop using ranlib (GH-10417)
    e1b2103

    @vstinner
    Copy link
    Member

    Maybe it would be possible to keep ranlib in Python 3.6, but it seems safe to remove it. The master doesn't use ranlib and the compilation is fine in our large fleet of buildbot workers.

    I chose to backport the change to be able to backport the clang LTO fix.

    @vstinner vstinner added the 3.8 only security fixes label Nov 29, 2018
    @vstinner
    Copy link
    Member

    clang LTO fix: bpo-28015

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes build The build process and cross-build
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @benjaminp