Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDLE: Add docstrings and tests for editor.py reload functions #75710

Open
csabella opened this issue Sep 20, 2017 · 4 comments
Open

IDLE: Add docstrings and tests for editor.py reload functions #75710

csabella opened this issue Sep 20, 2017 · 4 comments
Assignees
Labels
3.7 (EOL) end of life tests Tests in the Lib/test dir topic-IDLE type-feature A feature request or enhancement

Comments

@csabella
Copy link
Contributor

csabella commented Sep 20, 2017

BPO 31529
Nosy @terryjreedy, @csabella
PRs
  • gh-75710: IDLE: Add docstrings and tests to some editor.py functions #3669
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
    closed_at = None
    created_at = <Date 2017-09-20.13:06:20.730>
    labels = ['expert-IDLE', 'type-feature', '3.7']
    title = 'IDLE: Add docstrings and tests for editor.py reload functions'
    updated_at = <Date 2018-05-23.04:43:16.595>
    user = 'https://github.com/csabella'

    bugs.python.org fields:

    activity = <Date 2018-05-23.04:43:16.595>
    actor = 'terry.reedy'
    assignee = 'terry.reedy'
    closed = False
    closed_date = None
    closer = None
    components = ['IDLE']
    creation = <Date 2017-09-20.13:06:20.730>
    creator = 'cheryl.sabella'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 31529
    keywords = ['patch']
    message_count = 4.0
    messages = ['302609', '302704', '311623', '317352']
    nosy_count = 2.0
    nosy_names = ['terry.reedy', 'cheryl.sabella']
    pr_nums = ['3669']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue31529'
    versions = ['Python 3.6', 'Python 3.7']

    Linked PRs

    @csabella
    Copy link
    Contributor Author

    Add docstrings and unit tests for a subset of functions in editor.py, including functions related to creating the menubar, adding keybinding events, and reloading the editor from configdialog.

    @csabella csabella added the 3.7 (EOL) end of life label Sep 20, 2017
    @csabella csabella added topic-IDLE type-feature A feature request or enhancement labels Sep 20, 2017
    @terryjreedy
    Copy link
    Member

    A good start, and big enough as it is, for the next big revision project ;-).

    @csabella
    Copy link
    Contributor Author

    csabella commented Feb 4, 2018

    Hi Terry,

    Could you put this one on your radar for review? Thanks!

    @terryjreedy
    Copy link
    Member

    There is a reference to this issue in bpo-31494, msg302628 (CodeContext loops).

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @erlend-aasland erlend-aasland added the tests Tests in the Lib/test dir label Jul 27, 2022
    terryjreedy added a commit to terryjreedy/cpython that referenced this issue May 13, 2023
    Commit extracted from PR python#3669.  Will edits more later.
    
    Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
    terryjreedy added a commit that referenced this issue May 13, 2023
    Commit extracted from PR #3669.  Will edit more later.
    
    Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
    miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 13, 2023
    …ythonGH-104446)
    
    Commit extracted from PR pythonGH-3669.  Will edit more later.
    
    (cherry picked from commit 46f1c78)
    
    Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
    Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
    terryjreedy added a commit that referenced this issue May 13, 2023
    …H-104446) (#104450)
    
    gh-75710: IDLE - add docstrings and comments to editor module (GH-104446)
    
    Commit extracted from PR GH-3669.  Will edit more later.
    
    (cherry picked from commit 46f1c78)
    
    Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
    Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
    carljm added a commit to carljm/cpython that referenced this issue May 15, 2023
    * main: (29 commits)
      pythongh-101819: Fix _io clinic input for unused base class method stubs (python#104418)
      pythongh-101819: Isolate `_io` (python#101948)
      Bump mypy from 1.2.0 to 1.3.0 in /Tools/clinic (python#104501)
      pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (python#104495)
      pythongh-104050: Run mypy on `clinic.py` in CI (python#104421)
      pythongh-104490: Consistently define phony make targets (python#104491)
      pythongh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined (python#104473)
      pythongh-104487: PYTHON_FOR_REGEN must be minimum Python 3.10 (python#104488)
      pythongh-101282: move BOLT config after PGO (pythongh-104493)
      pythongh-104469 Convert _testcapi/float.c to use AC (pythongh-104470)
      pythongh-104456: Fix ref leak in _ctypes.COMError (python#104457)
      pythongh-98539: Make _SSLTransportProtocol.abort() safe to call when closed (python#104474)
      pythongh-104337: Clarify random.gammavariate doc entry  (python#104410)
      Minor improvements to typing docs (python#104465)
      pythongh-87092: avoid gcc warning on uninitialized struct field in assemble.c (python#104460)
      pythonGH-71383: IDLE - Document testing subsets of modules (python#104463)
      pythongh-104454: Fix refleak in AttributeError_reduce (python#104455)
      pythongh-75710: IDLE - add docstrings and comments to editor module (python#104446)
      pythongh-91896: Revert some very noisy DeprecationWarnings for `ByteString` (python#104424)
      Add a mention of PYTHONBREAKPOINT to breakpoint() docs (python#104430)
      ...
    carljm added a commit to carljm/cpython that referenced this issue May 15, 2023
    * main: (204 commits)
      pythongh-101819: Fix _io clinic input for unused base class method stubs (python#104418)
      pythongh-101819: Isolate `_io` (python#101948)
      Bump mypy from 1.2.0 to 1.3.0 in /Tools/clinic (python#104501)
      pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (python#104495)
      pythongh-104050: Run mypy on `clinic.py` in CI (python#104421)
      pythongh-104490: Consistently define phony make targets (python#104491)
      pythongh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined (python#104473)
      pythongh-104487: PYTHON_FOR_REGEN must be minimum Python 3.10 (python#104488)
      pythongh-101282: move BOLT config after PGO (pythongh-104493)
      pythongh-104469 Convert _testcapi/float.c to use AC (pythongh-104470)
      pythongh-104456: Fix ref leak in _ctypes.COMError (python#104457)
      pythongh-98539: Make _SSLTransportProtocol.abort() safe to call when closed (python#104474)
      pythongh-104337: Clarify random.gammavariate doc entry  (python#104410)
      Minor improvements to typing docs (python#104465)
      pythongh-87092: avoid gcc warning on uninitialized struct field in assemble.c (python#104460)
      pythonGH-71383: IDLE - Document testing subsets of modules (python#104463)
      pythongh-104454: Fix refleak in AttributeError_reduce (python#104455)
      pythongh-75710: IDLE - add docstrings and comments to editor module (python#104446)
      pythongh-91896: Revert some very noisy DeprecationWarnings for `ByteString` (python#104424)
      Add a mention of PYTHONBREAKPOINT to breakpoint() docs (python#104430)
      ...
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life tests Tests in the Lib/test dir topic-IDLE type-feature A feature request or enhancement
    Projects
    Status: In Progress
    Development

    No branches or pull requests

    3 participants