Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require sqlite3_prepare_v2 #75706

Closed
benjaminp opened this issue Sep 20, 2017 · 6 comments
Closed

require sqlite3_prepare_v2 #75706

benjaminp opened this issue Sep 20, 2017 · 6 comments
Labels
3.7 (EOL) end of life extension-modules C modules in the Modules dir

Comments

@benjaminp
Copy link
Contributor

BPO 31525
Nosy @benjaminp, @berkerpeksag, @miss-islington
PRs
  • closes bpo-31525: require sqlite3_prepare_v2 #3666
  • bpo-31525: Increase minimum sqlite version number check #12923
  • [3.7] bpo-31525: Increase minimum sqlite version number check (GH-12923) #12972
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-09-20.14:36:20.661>
created_at = <Date 2017-09-20.01:47:44.689>
labels = ['extension-modules', '3.7']
title = 'require sqlite3_prepare_v2'
updated_at = <Date 2019-04-26.16:15:34.486>
user = 'https://github.com/benjaminp'

    bugs.python.org fields:

    activity = <Date 2019-04-26.16:15:34.486>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2017-09-20.14:36:20.661>
closer = 'benjamin.peterson'
components = ['Extension Modules']
creation = <Date 2017-09-20.01:47:44.689>
creator = 'benjamin.peterson'
dependencies = []
files = []
hgrepos = []
issue_num = 31525
keywords = ['patch']
message_count = 6.0
messages = ['302581', '302585', '302588', '302622', '340925', '340929']
nosy_count = 3.0
nosy_names = ['benjamin.peterson', 'berker.peksag', 'miss-islington']
pr_nums = ['3666', '12923', '12972']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue31525'
versions = ['Python 3.7']
    @benjaminp
    Copy link
    Contributor Author

    sqlite has had the sqlite3_prepare_v2 API for more than 10 years now. The sqlite module should switch to using it, which will let us delete some code for automatically recompiling statements.

    @benjaminp benjaminp added 3.7 (EOL) end of life extension-modules C modules in the Modules dir labels Sep 20, 2017
    @berkerpeksag
    Copy link
    Member

    We already use sqlite3_prepare_v2 if it's available: https://github.com/python/cpython/blob/master/Modules/_sqlite/util.h#L43

    Do you want to use sqlite3_prepare_v2() unconditionally and drop support for older SQLite versions?

    @benjaminp
    Copy link
    Contributor Author

    ermm, yes, I guess I was looking at an old version of the code.

    @benjaminp benjaminp changed the title switch to sqlite3_prepare_v2 require sqlite3_prepare_v2 Sep 20, 2017
    @benjaminp
    Copy link
    Contributor Author

    New changeset 5252694 by Benjamin Peterson in branch 'master':
    closes bpo-31525: require sqlite3_prepare_v2 (bpo-3666)
    5252694

    @berkerpeksag
    Copy link
    Member

    New changeset ad0daf5 by Berker Peksag (Charles Pigott) in branch 'master':
    bpo-31525: Increase minimum sqlite version number check (GH-12923)
    ad0daf5

    @miss-islington
    Copy link
    Contributor

    New changeset 967f14e by Miss Islington (bot) in branch '3.7':
    bpo-31525: Increase minimum sqlite version number check (GH-12923)
    967f14e

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life extension-modules C modules in the Modules dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @berkerpeksag @benjaminp @miss-islington