Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertion failures in warn_explicit() in case of a bad warnings.filters or warnings.defaultaction #75597

Closed
orenmn mannequin opened this issue Sep 11, 2017 · 3 comments
Closed
Labels
3.7 (EOL) end of life extension-modules C modules in the Modules dir type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@orenmn
Copy link
Mannequin

orenmn mannequin commented Sep 11, 2017

BPO 31416
Nosy @serhiy-storchaka, @orenmn
PRs
  • bpo-31416: Fix assertion failures in case of a bad warnings.filters or warnings.defaultaction #3496
  • [3.6] bpo-31416: Fix assertion failures in case of a bad warnings.fil… #3509
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-09-12.06:48:53.490>
    created_at = <Date 2017-09-11.07:52:58.758>
    labels = ['extension-modules', '3.7', 'type-crash']
    title = 'assertion failures in warn_explicit() in case of a bad warnings.filters or warnings.defaultaction'
    updated_at = <Date 2017-09-12.06:48:53.489>
    user = 'https://github.com/orenmn'

    bugs.python.org fields:

    activity = <Date 2017-09-12.06:48:53.489>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-09-12.06:48:53.490>
    closer = 'serhiy.storchaka'
    components = ['Extension Modules']
    creation = <Date 2017-09-11.07:52:58.758>
    creator = 'Oren Milman'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 31416
    keywords = ['patch']
    message_count = 3.0
    messages = ['301867', '301903', '301940']
    nosy_count = 2.0
    nosy_names = ['serhiy.storchaka', 'Oren Milman']
    pr_nums = ['3496', '3509']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'crash'
    url = 'https://bugs.python.org/issue31416'
    versions = ['Python 3.7']

    @orenmn
    Copy link
    Mannequin Author

    orenmn mannequin commented Sep 11, 2017

    The following code causes an assertion failure in warn_explicit() (in
    Python/_warnings.c):

    import warnings
    warnings.filters = [(None, None, Warning, None, 0)]
    warnings.warn_explicit(message='foo', category=Warning, filename='bar',
                           lineno=1)

    this is because warn_explicit() assumes that get_filter() returned a string,
    and passes the return value (of get_filter()) to _PyUnicode_EqualToASCIIString(),
    which asserts it received a string.

    In addition, get_filter() might return warnings.defaultaction, and so the
    following code also causes an assertion failure in warn_explicit():

    import warnings
    warnings.defaultaction = None
    warnings.filters = []
    warnings.warn_explicit(message='foo', category=Warning, filename='bar',
                           lineno=1)

    @orenmn orenmn mannequin added 3.7 (EOL) end of life extension-modules C modules in the Modules dir type-crash A hard crash of the interpreter, possibly with a core dump labels Sep 11, 2017
    @serhiy-storchaka
    Copy link
    Member

    New changeset 9d984fd by Serhiy Storchaka (Oren Milman) in branch 'master':
    bpo-31416: Fix assertion failures in case of a bad warnings.filters or warnings.defaultaction. (bpo-3496)
    9d984fd

    @serhiy-storchaka
    Copy link
    Member

    New changeset 9adc87b by Serhiy Storchaka in branch '3.6':
    [3.6] bpo-31416: Fix assertion failures in case of a bad warnings.filters or warnings.defaultaction. (GH-3496) (bpo-3509)
    9adc87b

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life extension-modules C modules in the Modules dir type-crash A hard crash of the interpreter, possibly with a core dump
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant