Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSL module returns incorrect error codes on Windows #75581

Closed
zooba opened this issue Sep 8, 2017 · 4 comments
Closed

SSL module returns incorrect error codes on Windows #75581

zooba opened this issue Sep 8, 2017 · 4 comments
Assignees
@zooba
Labels
3.7 (EOL) end of life topic-SSL type-bug An unexpected behavior, bug, or error

Comments

@zooba
Copy link
Member

zooba commented Sep 8, 2017

BPO 31400
Nosy @tiran, @alex, @zooba, @dstufft
PRs
  • bpo-31400: Improve SSL error handling on Windows #3463
  • [3.6] bpo-31400: Improve SSL error handling on Windows (GH-3463) #3466
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2017-09-11.10:25:24.698>
created_at = <Date 2017-09-08.21:16:30.722>
labels = ['expert-SSL', 'type-bug', '3.7']
title = 'SSL module returns incorrect error codes on Windows'
updated_at = <Date 2017-09-11.10:25:24.696>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2017-09-11.10:25:24.696>
actor = 'christian.heimes'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2017-09-11.10:25:24.698>
closer = 'christian.heimes'
components = ['SSL']
creation = <Date 2017-09-08.21:16:30.722>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 31400
keywords = ['patch']
message_count = 4.0
messages = ['301733', '301743', '301775', '301870']
nosy_count = 5.0
nosy_names = ['janssen', 'christian.heimes', 'alex', 'steve.dower', 'dstufft']
pr_nums = ['3463', '3466']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue31400'
versions = ['Python 3.6', 'Python 3.7']
    @zooba
    Copy link
    Member Author

    zooba commented Sep 8, 2017

    Because we wait so long between errors occurring and being reported, information about the Windows error code (WSAGetLastError) has already been lost.

    We should capture all the info sooner.

    @zooba zooba added the 3.7 (EOL) end of life label Sep 8, 2017
    @zooba zooba self-assigned this Sep 8, 2017
    @zooba zooba added topic-SSL type-bug An unexpected behavior, bug, or error labels Sep 8, 2017
    @tiran
    Copy link
    Member

    tiran commented Sep 8, 2017

    New changeset e6eb48c by Christian Heimes (Steve Dower) in branch 'master':
    bpo-31400: Improve SSL error handling on Windows (bpo-3463)
    e6eb48c

    @tiran
    Copy link
    Member

    tiran commented Sep 9, 2017

    New changeset 16f16db by Christian Heimes in branch '3.6':
    [3.6] bpo-31400: Improve SSL error handling on Windows (GH-3463) (bpo-3466)
    16f16db

    @tiran
    Copy link
    Member

    tiran commented Sep 11, 2017

    Patch has landed in 3.6 and master, thanks!

    @tiran tiran closed this as completed Sep 11, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.7 (EOL) end of life topic-SSL type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @tiran @zooba