Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull zlib out to cpython-source-deps #75539

Closed
zware opened this issue Sep 6, 2017 · 3 comments
Closed

Pull zlib out to cpython-source-deps #75539

zware opened this issue Sep 6, 2017 · 3 comments
Labels
3.7 (EOL) end of life build The build process and cross-build OS-windows type-feature A feature request or enhancement

Comments

@zware
Copy link
Member

zware commented Sep 6, 2017

BPO 31358
Nosy @doko42, @pfmoore, @tjguk, @zware, @zooba
PRs
  • bpo-31358: Pull zlib out of the repository #3375
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-09-07.00:34:51.421>
created_at = <Date 2017-09-06.00:43:52.330>
labels = ['type-feature', '3.7', 'OS-windows', 'build']
title = 'Pull zlib out to cpython-source-deps'
updated_at = <Date 2017-09-07.00:34:51.421>
user = 'https://github.com/zware'

    bugs.python.org fields:

    activity = <Date 2017-09-07.00:34:51.421>
actor = 'zach.ware'
assignee = 'none'
closed = True
closed_date = <Date 2017-09-07.00:34:51.421>
closer = 'zach.ware'
components = ['Build', 'Windows']
creation = <Date 2017-09-06.00:43:52.330>
creator = 'zach.ware'
dependencies = []
files = []
hgrepos = []
issue_num = 31358
keywords = []
message_count = 3.0
messages = ['301418', '301442', '301552']
nosy_count = 5.0
nosy_names = ['doko', 'paul.moore', 'tim.golden', 'zach.ware', 'steve.dower']
pr_nums = ['3375']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue31358'
versions = ['Python 3.7']
    @zware
    Copy link
    Member Author

    zware commented Sep 6, 2017

    We currently bundle zlib in our source at Modules/zlib, but it is only used on Windows. The soon-to-be-attached PR instead pulls it from https://github.com/python/cpython-source-deps

    There is one failure in test_venv only when zlib is not built at all, which I have not yet investigated.

    /cc doko as the most recent updater of the bundled copy of zlib.

    @zware zware added 3.7 (EOL) end of life build The build process and cross-build OS-windows type-feature A feature request or enhancement labels Sep 6, 2017
    @doko42
    Copy link
    Member

    doko42 commented Sep 6, 2017

    +1, if that's ok with the Windows maintainers.

    @zware
    Copy link
    Member Author

    zware commented Sep 7, 2017

    New changeset d01db1c by Zachary Ware in branch 'master':
    bpo-31358: Pull zlib out of the repository (GH-3375)
    d01db1c

    @zware zware closed this as completed Sep 7, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life build The build process and cross-build OS-windows type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zware @doko42