Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shutil references undefined WindowsError symbol #47384

Closed
dvitek mannequin opened this issue Jun 18, 2008 · 7 comments
Closed

shutil references undefined WindowsError symbol #47384

dvitek mannequin opened this issue Jun 18, 2008 · 7 comments
Assignees
@pitrou
Labels
stdlib Python modules in the Lib dir type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@dvitek
Copy link
Mannequin

dvitek mannequin commented Jun 18, 2008

BPO 3134
Nosy @pitrou
Files
  • p.patch: patch for shutil.py
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/pitrou'
closed_at = <Date 2008-08-11.17:21:57.250>
created_at = <Date 2008-06-18.20:49:09.590>
labels = ['library', 'type-crash']
title = 'shutil references undefined WindowsError symbol'
updated_at = <Date 2008-08-11.17:21:57.199>
user = 'https://bugs.python.org/dvitek'

    bugs.python.org fields:

    activity = <Date 2008-08-11.17:21:57.199>
actor = 'pitrou'
assignee = 'pitrou'
closed = True
closed_date = <Date 2008-08-11.17:21:57.250>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2008-06-18.20:49:09.590>
creator = 'dvitek'
dependencies = []
files = ['10655']
hgrepos = []
issue_num = 3134
keywords = ['patch']
message_count = 7.0
messages = ['68373', '68374', '68420', '70946', '71006', '71020', '71023']
nosy_count = 3.0
nosy_names = ['pitrou', 'draghuram', 'dvitek']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue3134'
versions = ['Python 2.6', 'Python 3.0']
    @dvitek
    Copy link
    Mannequin Author

    dvitek mannequin commented Jun 18, 2008

    If copystat fails in copytree on a non-windows box, you will get:

    NameError: global name 'WindowsError' is not defined:
    ...
    except WindowsError:

    @dvitek dvitek mannequin added stdlib Python modules in the Lib dir type-crash A hard crash of the interpreter, possibly with a core dump labels Jun 18, 2008
    @draghuram
    Copy link
    Mannequin

    draghuram mannequin commented Jun 18, 2008

    This is same as bpo-2549 which also reported the same problem. In fact, the
    problem was originally found in bpo-1545. As I said there, the proposed
    patch has a very small problem. Can you please take a look?

    @draghuram
    Copy link
    Mannequin

    draghuram mannequin commented Jun 19, 2008

    I submitted a patch at http://codereview.appspot.com/2384. Please take a
    look.

    @pitrou
    Copy link
    Member

    pitrou commented Aug 9, 2008

    Raghuram, your patch looks good to me. I'll try to test it under Windows
    soon.

    @pitrou
    Copy link
    Member

    pitrou commented Aug 11, 2008

    Patch works under Windows.

    @pitrou pitrou self-assigned this Aug 11, 2008
    @draghuram
    Copy link
    Mannequin

    draghuram mannequin commented Aug 11, 2008

    Patch works under Windows.

    Thanks. Can you please commit the change?

    @pitrou
    Copy link
    Member

    pitrou commented Aug 11, 2008

    Fixed in r65644.

    @pitrou pitrou closed this as completed Aug 11, 2008
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @pitrou pitrou

    Labels
    stdlib Python modules in the Lib dir type-crash A hard crash of the interpreter, possibly with a core dump
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @pitrou