Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE, configdialog: Factor out HighPage class from ConfigDialog #75389

Closed
terryjreedy opened this issue Aug 15, 2017 · 12 comments
Closed

IDLE, configdialog: Factor out HighPage class from ConfigDialog #75389

terryjreedy opened this issue Aug 15, 2017 · 12 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life topic-IDLE type-feature A feature request or enhancement

Comments

@terryjreedy
Copy link
Member

BPO 31206
Nosy @terryjreedy, @csabella
PRs
  • bpo-31206: IDLE: Factor HighPage class from ConfigDialog #3141
  • [3.6] bpo-31206: IDLE: Factor HighPage class from ConfigDialog (GH-3141) #3154
  • bpo-31206: IDLE: Factor HighPage class from ConfigDialog #3156
  • [3.6] bpo-31206: IDLE: Factor HighPage class from ConfigDialog (GH-3156) #3159
  • bpo-31206: IDLE: Factor HighPage class from ConfigDialog #3160
  • [3.6] bpo-31206: IDLE: Factor HighPage class from ConfigDialog (GH-3160) #3162
    		•
    Dependencies
  • bpo-31001: IDLE: Add tests for configdialog highlight tab
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2017-08-20.23:22:51.685>
created_at = <Date 2017-08-15.01:48:57.809>
labels = ['expert-IDLE', 'type-feature', '3.7']
title = 'IDLE, configdialog: Factor out HighPage class from ConfigDialog'
updated_at = <Date 2017-08-20.23:22:51.684>
user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2017-08-20.23:22:51.684>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2017-08-20.23:22:51.685>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2017-08-15.01:48:57.809>
creator = 'terry.reedy'
dependencies = ['31001']
files = []
hgrepos = []
issue_num = 31206
keywords = []
message_count = 12.0
messages = ['300278', '300319', '300465', '300543', '300545', '300582', '300591', '300592', '300599', '300600', '300601', '300612']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'cheryl.sabella']
pr_nums = ['3141', '3154', '3156', '3159', '3160', '3162']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue31206'
versions = ['Python 3.6', 'Python 3.7']
    @terryjreedy
    Copy link
    Member Author

    As with bpo-31050, bpo-31205

    @terryjreedy terryjreedy added the 3.7 (EOL) end of life label Aug 15, 2017
    @terryjreedy terryjreedy self-assigned this Aug 15, 2017
    @terryjreedy terryjreedy added topic-IDLE type-feature A feature request or enhancement labels Aug 15, 2017
    @terryjreedy
    Copy link
    Member Author

    The configdialog diff for bpo-31205 was so jumbled that it did not apply correctly to 3.6. Let's do this in 2 PRs. First adds the class to how we think it should be. The second deletes the old code, makes any edits needed for the new class, and redirects the tests.

    @terryjreedy
    Copy link
    Member Author

    Delete frame.highlight_sample when frame becomes self.
    text = self.highlight_sample = frame.highlight_sample = Text(

    Change coverage to 95% when edit test file.

    @terryjreedy
    Copy link
    Member Author

    New changeset a32e405 by Terry Jan Reedy (Cheryl Sabella) in branch 'master':
    bpo-31206: IDLE: Factor HighPage class from ConfigDialog (bpo-3141)
    a32e405

    @terryjreedy
    Copy link
    Member Author

    I cannot do the backport at the moment, so at your convenience, please run cherry picker for PR3141 for 3.6. You can submit the 2nd PR for 3.7 without waiting for me to merge the backport.

    @terryjreedy
    Copy link
    Member Author

    New changeset 764e282 by Terry Jan Reedy (Cheryl Sabella) in branch '3.6':
    [3.6] bpo-31206: IDLE: Factor HighPage class from ConfigDialog (GH-3141) (bpo-3154)
    764e282

    @terryjreedy
    Copy link
    Member Author

    New changeset 8f7a798 by Terry Jan Reedy (Cheryl Sabella) in branch 'master':
    bpo-31206: IDLE: Factor HighPage class from ConfigDialog (bpo-3156)
    8f7a798

    @terryjreedy
    Copy link
    Member Author

    Ditto last message for PR3156 and 3rd patch deleting old code now dead. In retrospect, we could have done first and second patches together. Deleting or commenting out a large existing block along with other changes triggers the nonsense diff. Let's see if a simple delete can be handled.

    @terryjreedy
    Copy link
    Member Author

    New changeset 3d9c0d4 by Terry Jan Reedy (Cheryl Sabella) in branch '3.6':
    [3.6] bpo-31206: IDLE: Factor HighPage class from ConfigDialog (GH-3156) (bpo-3159)
    3d9c0d4

    @terryjreedy
    Copy link
    Member Author

    New changeset 4bfebc6 by Terry Jan Reedy (Cheryl Sabella) in branch 'master':
    bpo-31206: IDLE: Factor HighPage class from ConfigDialog (bpo-3160)
    4bfebc6

    @terryjreedy
    Copy link
    Member Author

    Ditto backport for pr3160.

    @terryjreedy
    Copy link
    Member Author

    New changeset 24c0c5b by Terry Jan Reedy (Cheryl Sabella) in branch '3.6':
    [3.6] bpo-31206: IDLE: Factor HighPage class from ConfigDialog (GH-3160) (bpo-3162)
    24c0c5b

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @terryjreedy