Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous errors in asyncio speedup module #75368

Closed
serhiy-storchaka opened this issue Aug 11, 2017 · 9 comments
Closed

Miscellaneous errors in asyncio speedup module #75368

serhiy-storchaka opened this issue Aug 11, 2017 · 9 comments
Labels
3.7 (EOL) end of life extension-modules C modules in the Modules dir topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

BPO 31185
Nosy @vstinner, @giampaolo, @methane, @cjerdonek, @serhiy-storchaka, @1st1
PRs
  • bpo-31185: Fixed miscellaneous errors in asyncio speedup module. #3076
  • bpo-31185: Fixed miscellaneous errors in asyncio speedup module. (#3076) #3269
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-09-03.06:31:28.354>
created_at = <Date 2017-08-11.16:28:18.591>
labels = ['extension-modules', 'type-bug', '3.7', 'expert-asyncio']
title = 'Miscellaneous errors in asyncio speedup module'
updated_at = <Date 2020-05-08.08:17:05.358>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2020-05-08.08:17:05.358>
actor = 'chris.jerdonek'
assignee = 'none'
closed = True
closed_date = <Date 2017-09-03.06:31:28.354>
closer = 'serhiy.storchaka'
components = ['Extension Modules', 'asyncio']
creation = <Date 2017-08-11.16:28:18.591>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 31185
keywords = []
message_count = 9.0
messages = ['300171', '300172', '300174', '300175', '300176', '300177', '301183', '301184', '368427']
nosy_count = 6.0
nosy_names = ['vstinner', 'giampaolo.rodola', 'methane', 'chris.jerdonek', 'serhiy.storchaka', 'yselivanov']
pr_nums = ['3076', '3269']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue31185'
versions = ['Python 3.6', 'Python 3.7']
    @serhiy-storchaka
    Copy link
    Member Author

    Proposed patch fixes miscellaneous errors in asyncio speedup module. It is hard to enumerate they all, but they are mostly NULL dereferencing, reference leaks, and handling exceptions in corner cases.

    @serhiy-storchaka serhiy-storchaka added 3.7 (EOL) end of life extension-modules C modules in the Modules dir topic-asyncio type-bug An unexpected behavior, bug, or error labels Aug 11, 2017
    @1st1
    Copy link
    Member

    1st1 commented Aug 11, 2017

    Adding INADA, he is a co-author/reviewer of that code.

    @1st1
    Copy link
    Member

    1st1 commented Aug 11, 2017

    Huge thanks, Serhiy, btw.

    @vstinner
    Copy link
    Member

    "reference leaks" oh? our Refleaks buildbots didn't catch them. Do your new tests reproduce the bugs, to make sure that we don't leak anymore?

    @1st1
    Copy link
    Member

    1st1 commented Aug 11, 2017

    "reference leaks" oh? our Refleaks buildbots didn't catch them.

    The test suite for Tasks and Futures is pretty extensive, but it obviously doesn't cover some obscure use cases.

    +1 to make sure that any refleak that was discovered should have a new regression test for it.

    @serhiy-storchaka
    Copy link
    Member Author

    They are occurred in very obscure cases like calling __init__ multiple times. The patch doesn't contain tests for them.

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset bca4939 by Serhiy Storchaka in branch 'master':
    bpo-31185: Fixed miscellaneous errors in asyncio speedup module. (bpo-3076)
    bca4939

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 98bbeb7 by Serhiy Storchaka in branch '3.6':
    bpo-31185: Fixed miscellaneous errors in asyncio speedup module. (bpo-3076) (bpo-3269)
    98bbeb7

    @cjerdonek
    Copy link
    Member

    FYI, there is a missing Py_DECREF from this change: https://bugs.python.org/issue40559
    (though it's an obscure code path as mentioned elsewhere in these comments)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life extension-modules C modules in the Modules dir topic-asyncio type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @vstinner @1st1 @cjerdonek @serhiy-storchaka