Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline module has obsolete code #75129

Closed
pitrou opened this issue Jul 17, 2017 · 3 comments
Closed

readline module has obsolete code #75129

pitrou opened this issue Jul 17, 2017 · 3 comments
Labels
3.7 (EOL) end of life extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@pitrou
Copy link
Member

pitrou commented Jul 17, 2017

BPO 30946
Nosy @pitrou
PRs
  • bpo-30946: Remove obsolete fallback code in readline module #2738
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-07-18.15:05:24.209>
created_at = <Date 2017-07-17.10:31:54.238>
labels = ['extension-modules', 'type-feature', '3.7']
title = 'readline module has obsolete code'
updated_at = <Date 2017-07-18.15:05:24.208>
user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2017-07-18.15:05:24.208>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2017-07-18.15:05:24.209>
closer = 'pitrou'
components = ['Extension Modules']
creation = <Date 2017-07-17.10:31:54.238>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 30946
keywords = []
message_count = 3.0
messages = ['298479', '298480', '298594']
nosy_count = 1.0
nosy_names = ['pitrou']
pr_nums = ['2738']
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue30946'
versions = ['Python 3.7']
    @pitrou
    Copy link
    Member Author

    pitrou commented Jul 17, 2017

    The readline module has obsolete code for platforms where GNU readline is older than 2.1 or where select() is not available.

    @pitrou pitrou added 3.7 (EOL) end of life extension-modules C modules in the Modules dir type-feature A feature request or enhancement labels Jul 17, 2017
    @pitrou
    Copy link
    Member Author

    pitrou commented Jul 17, 2017

    According to https://ftp.gnu.org/gnu/readline/, GNU readline 2.1 was released in 1997... We could probably even require 5.0 (released in 2004), but it raises the question of which functions are supported by third-party emulations such as libedit.

    @pitrou
    Copy link
    Member Author

    pitrou commented Jul 18, 2017

    New changeset f474c5a by Antoine Pitrou in branch 'master':
    bpo-30946: Remove obsolete fallback code in readline module (bpo-2738)
    f474c5a

    @pitrou pitrou closed this as completed Jul 18, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life extension-modules C modules in the Modules dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @pitrou