Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject environment variable names containing '=' #74931

Closed
serhiy-storchaka opened this issue Jun 24, 2017 · 6 comments
Closed

Reject environment variable names containing '=' #74931

serhiy-storchaka opened this issue Jun 24, 2017 · 6 comments
Labels
3.7 (EOL) end of life extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

BPO 30746
Nosy @loewis, @larryhastings, @serhiy-storchaka
PRs
  • bpo-30746: Prohibited the '=' character in environment variable names #2382
  • [3.6] bpo-30746: Prohibited the '=' character in environment variable names (GH-2382) #2391
  • [3.5] bpo-30746: Prohibited the '=' character in environment variable names (GH-2382) #2392
  • [2.7] bpo-30746: Prohibited the '=' character in environment variable names (GH-2382) #2393
  • bpo-30746: Port more tests for os.spawnvpe() and os.execve() from 2.7. #2394
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-06-25.06:51:00.176>
created_at = <Date 2017-06-24.19:05:15.137>
labels = ['extension-modules', 'type-bug', '3.7']
title = "Reject environment variable names containing '='"
updated_at = <Date 2017-06-25.06:51:00.175>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2017-06-25.06:51:00.175>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2017-06-25.06:51:00.176>
closer = 'serhiy.storchaka'
components = ['Extension Modules']
creation = <Date 2017-06-24.19:05:15.137>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 30746
keywords = []
message_count = 6.0
messages = ['296781', '296802', '296811', '296812', '296813', '296814']
nosy_count = 3.0
nosy_names = ['loewis', 'larry', 'serhiy.storchaka']
pr_nums = ['2382', '2391', '2392', '2393', '2394']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue30746'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6', 'Python 3.7']
    @serhiy-storchaka
    Copy link
    Member Author

    Environment variable names shouldn't contain the '=' character, because it often is used as a separator between a name and a value. There is an exception -- starting '=' on Windows is used for defining "hidden" environment variables.

    Using names containing '=' in environment dict in subprocess is prohibited in bpo-30730. Proposed PR prohibits names containing '=' in two other cases: in os.putenv() and os.spawn*(). It fixes the part of bpo-4926.

    @serhiy-storchaka serhiy-storchaka added 3.7 (EOL) end of life extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error labels Jun 24, 2017
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 7770394 by Serhiy Storchaka in branch 'master':
    bpo-30746: Prohibited the '=' character in environment variable names (bpo-2382)
    7770394

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset af5392f by Serhiy Storchaka in branch 'master':
    bpo-30746: Port more tests for os.spawnvpe() and os.execve() from 2.7. (bpo-2394)
    af5392f

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 9c2dc0c by Serhiy Storchaka in branch '3.6':
    [3.6] bpo-30746: Prohibited the '=' character in environment variable names (GH-2382) (bpo-2391)
    9c2dc0c

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 99e9eb6 by Serhiy Storchaka in branch '3.5':
    [3.5] bpo-30746: Prohibited the '=' character in environment variable names (GH-2382) (bpo-2392)
    99e9eb6

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 787826c by Serhiy Storchaka in branch '2.7':
    [2.7] bpo-30746: Prohibited the '=' character in environment variable names (GH-2382) (bpo-2393)
    787826c

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @serhiy-storchaka