Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct executable manifest for windows #74916

Closed
tumagonx mannequin opened this issue Jun 22, 2017 · 6 comments
Closed

Use correct executable manifest for windows #74916

tumagonx mannequin opened this issue Jun 22, 2017 · 6 comments
Assignees
@zooba
Labels
3.7 (EOL) end of life OS-windows type-feature A feature request or enhancement

Comments

@tumagonx
Copy link
Mannequin

tumagonx mannequin commented Jun 22, 2017

BPO 30731
Nosy @pfmoore, @tjguk, @zware, @zooba
PRs
  • bpo-30731: python.manifest fix #2328
  • [3.6] bpo-30731: python.manifest fix (#2328) #2699
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2017-07-13.19:52:27.150>
created_at = <Date 2017-06-22.09:33:42.489>
labels = ['type-feature', '3.7', 'OS-windows']
title = 'Use correct executable manifest for windows'
updated_at = <Date 2017-07-13.19:52:27.149>
user = 'https://bugs.python.org/tumagonx'

    bugs.python.org fields:

    activity = <Date 2017-07-13.19:52:27.149>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2017-07-13.19:52:27.150>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2017-06-22.09:33:42.489>
creator = 'tumagonx'
dependencies = []
files = []
hgrepos = []
issue_num = 30731
keywords = []
message_count = 6.0
messages = ['296619', '296628', '296637', '296657', '298309', '298310']
nosy_count = 5.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'tumagonx']
pr_nums = ['2328', '2699']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue30731'
versions = ['Python 3.6', 'Python 3.7']
    @tumagonx
    Copy link
    Mannequin Author

    tumagonx mannequin commented Jun 22, 2017

    I think there is typo in python default manifest (applies to exe dll and pyd) in official installation.

    currently written as:
    <trustinfo>
    ...
    </trustInfo>

    should be:
    <trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
    ...
    </trustInfo>

    notice the lowercase "i" in incorrect manifest

    @tumagonx tumagonx mannequin added the type-feature A feature request or enhancement label Jun 22, 2017
    @zooba
    Copy link
    Member

    zooba commented Jun 22, 2017

    What is the impact of this error? I know of people who are relying on the manifest who have not raised any issue, so perhaps it isn't actually that important?

    @tumagonx
    Copy link
    Mannequin Author

    tumagonx mannequin commented Jun 22, 2017

    Not really, just want to be correct... AFAIK wrong manifest like that will prevent execution on older Windows such XP saying application not configured properly. Apparently earlier Windows has been stricter. But it's not like official python 3.6 support XP.

    @tumagonx
    Copy link
    Mannequin Author

    tumagonx mannequin commented Jun 23, 2017

    @Segev
    oops, must be my own typo "i" when I try repair the manifest. sorry about that.

    @zooba
    Copy link
    Member

    zooba commented Jul 13, 2017

    New changeset c40ad03 by Steve Dower (Segev Finer) in branch 'master':
    bpo-30731: python.manifest fix (bpo-2328)
    c40ad03

    @zooba
    Copy link
    Member

    zooba commented Jul 13, 2017

    New changeset d8e522f by Steve Dower in branch '3.6':
    bpo-30731: python.manifest fix (bpo-2328) (bpo-2699)
    d8e522f

    @zooba zooba added the 3.7 (EOL) end of life label Jul 13, 2017
    @zooba zooba closed this as completed Jul 13, 2017
    @zooba zooba self-assigned this Jul 13, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.7 (EOL) end of life OS-windows type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @tjguk @zooba