Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leak in test_c_locale_coercion #74820

Closed
matrixise opened this issue Jun 12, 2017 · 4 comments
Closed

Leak in test_c_locale_coercion #74820

matrixise opened this issue Jun 12, 2017 · 4 comments
Labels
3.7 (EOL) end of life type-bug An unexpected behavior, bug, or error

Comments

@matrixise
Copy link
Member

BPO 30635
Nosy @ncoghlan, @vstinner, @matrixise
PRs
  • bpo-30635: Fix refleak in test_c_locale_coercion #2126
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-06-13.12:31:33.601>
    created_at = <Date 2017-06-12.08:59:15.408>
    labels = ['type-bug', '3.7']
    title = 'Leak in test_c_locale_coercion'
    updated_at = <Date 2017-06-13.12:31:33.600>
    user = 'https://github.com/matrixise'

    bugs.python.org fields:

    activity = <Date 2017-06-13.12:31:33.600>
    actor = 'ncoghlan'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-06-13.12:31:33.601>
    closer = 'ncoghlan'
    components = []
    creation = <Date 2017-06-12.08:59:15.408>
    creator = 'matrixise'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 30635
    keywords = []
    message_count = 4.0
    messages = ['295759', '295760', '295907', '295912']
    nosy_count = 3.0
    nosy_names = ['ncoghlan', 'vstinner', 'matrixise']
    pr_nums = ['2126']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue30635'
    versions = ['Python 3.7']

    @matrixise
    Copy link
    Member Author

    ./python -m test -R 3:3 test_c_locale_coercion -m test_external_target_locale_configuration Mon 12 Jun 2017 10:57:14 AM CEST
    Run tests sequentially
    0:00:00 load avg: 1.31 [1/1] test_c_locale_coercion
    beginning 6 repetitions
    123456
    ......
    test_c_locale_coercion leaked [2, 2, 2] references, sum=6
    test_c_locale_coercion failed

    1 test failed:
    test_c_locale_coercion

    Total duration: 4 sec
    Tests result: FAILURE

    @matrixise matrixise added the 3.7 (EOL) end of life label Jun 12, 2017
    @vstinner
    Copy link
    Member

    Likely a leak in the implementation of the PEP-538, commit 6ea4186, bpo-28180.

    @ncoghlan
    Copy link
    Contributor

    New changeset 023564b by Nick Coghlan (Victor Stinner) in branch 'master':
    bpo-30635: Fix refleak in test_c_locale_coercion (bpo-2126)
    023564b

    @ncoghlan
    Copy link
    Contributor

    Technically a false alarm due to an unintended caching side effect in the test case.

    Victor fixed it by moving the list creation to the module setup fixture, so it only runs once, even when hunting refleaks.

    @ncoghlan ncoghlan added the type-bug An unexpected behavior, bug, or error label Jun 13, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants