New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selectors should use bare except clauses #74809
Comments
Right now it uses "except Exception: ...; raise" which does not take KeyboardInterrupt and SystemExit into account, leaving the fd in a bad state (it's not unregister()ed). |
I removed 3.4 from versions, since this is not a security fix. Does this need backport to 3.5 too? |
Look also at KqueueSelector.modify(). And the mentioning of SystemError in Misc/NEWS is wrong, it is a subclass of Exception. |
Serhiy Storchaka added the comment: Look also at KqueueSelector.modify(). And the mentioning of SystemError in I guess that he means SystemExit ;-) |
My apologies. The Misc/NEWS entry is correct. But only 2 of 3 "except Exception" are fixed. |
My bad. New PR: |
I see that on 3.6 except BaseException: is used, so the backport should not be necessary. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: