New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_os fails on non-English (Russian) Windows #74769
Comments
test_os fails on non-English (Russian) Windows 7 Home Extended 6.1.7601 x64 ====================================================================== Traceback (most recent call last):
File "C:\repos\cpython\lib\test\test_os.py", line 476, in test_access_denied
creationflags=DETACHED_PROCESS
File "C:\repos\cpython\lib\subprocess.py", line 293, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['icacls.exe', 'C:\\Users\\User\ \AppData\\Local\\Temp\\@test_6804_tmp', '/deny', 'Users:(S)']' returned non-zero exit status 1332. ---------------------------------------------------------------------- FAILED (errors=1, skipped=92) 1 test failed: Total duration: 5 sec There is no group BUILTIN\Users on my Windows. There is BUILTIN\Пользователи instead. |
On the Internet, I found: 1332 No mapping between account names and security IDs was done. The unit test:
|
Using the numeric SID instead of localized name in test_access_denied works for me (I've made PR). |
I merged your fix. Thanks! Let's wait for Windows buildbots. If tests pass on buildbots, the change should be backported to other branches impacted by the bug. http://buildbot.python.org/all/waterfall?category=3.x.stable&category=3.x.unstable |
Tests on Windows buildbots passed. I've made PR for 3.5 and 3.6 backporting. |
Thanks Denis Osipov for the fix and backports! |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: