Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the Integral ABC #47306

Closed
rhettinger opened this issue Jun 7, 2008 · 12 comments
Closed

Simplify the Integral ABC #47306

rhettinger opened this issue Jun 7, 2008 · 12 comments
Labels
stdlib Python modules in the Lib dir

Comments

@rhettinger
Copy link
Contributor

BPO 3056
Nosy @gvanrossum, @rhettinger, @ezio-melotti
Files
  • numbers2.diff: Diff for numbers.py
  • pep2.diff: Diff for the PEP
  • numbers3.diff: Path allowing right hand operand to override a binary operation
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2011-04-13.01:25:29.868>
created_at = <Date 2008-06-07.01:57:24.805>
labels = ['library']
title = 'Simplify the Integral ABC'
updated_at = <Date 2013-04-14.09:59:05.283>
user = 'https://github.com/rhettinger'

    bugs.python.org fields:

    activity = <Date 2013-04-14.09:59:05.283>
actor = 'python-dev'
assignee = 'jyasskin'
closed = True
closed_date = <Date 2011-04-13.01:25:29.868>
closer = 'rhettinger'
components = ['Library (Lib)']
creation = <Date 2008-06-07.01:57:24.805>
creator = 'rhettinger'
dependencies = []
files = ['10539', '10540', '10634']
hgrepos = []
issue_num = 3056
keywords = ['patch']
message_count = 12.0
messages = ['67792', '67826', '67941', '68253', '68256', '68318', '68332', '68333', '68991', '90103', '133631', '186901']
nosy_count = 5.0
nosy_names = ['gvanrossum', 'rhettinger', 'jyasskin', 'ezio.melotti', 'python-dev']
pr_nums = []
priority = 'low'
resolution = 'out of date'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue3056'
versions = ['Python 3.3']
    @rhettinger
    Copy link
    Contributor Author

    • Reduce Integral to just a single additional abstract method.
    • Supply the binary operations as mixins instead of abstract methods.
    • Three argument __pow__ is now optional.
    • Convert with __int__ instead of __long__.

    @rhettinger rhettinger added the stdlib Python modules in the Lib dir label Jun 7, 2008
    @rhettinger
    Copy link
    Contributor Author

    Is the patch good to go?

    @gvanrossum
    Copy link
    Member

    Not really, see the reply I sent to the checkin mail.

    @rhettinger
    Copy link
    Contributor Author

    Not much feedback on comp.lang.python.

    Does numbers3.diff look like what you had in mind?

    @gvanrossum
    Copy link
    Member

    Mostly, but I *really* want to see unittests for this.

    @gvanrossum gvanrossum assigned rhettinger and unassigned gvanrossum Jun 16, 2008
    @rhettinger
    Copy link
    Contributor Author

    Jeffrey, do you have an interest in taking it from here?

    @rhettinger rhettinger assigned jyasskin and unassigned rhettinger Jun 17, 2008
    @gvanrossum
    Copy link
    Member

    Raymond, mind if we roll back your previous (incorrect) changes? They
    really should not have been submitted in the first place.

    @rhettinger
    Copy link
    Contributor Author

    No problem. Whatever you think is best.

    Still hoping that Jeffrey can take a look at the mixin approach and the
    __rand__ logic. No one else seems to have an interest and I won't have
    time to write the tests for a few days (they are complicated because
    Integral requires so many abstract methods to be defined before it will
    instantiate).

    @jyasskin
    Copy link
    Mannequin

    jyasskin mannequin commented Jun 30, 2008

    Yeah, I'll take a look. Feel free to bug me if I haven't gotten to it in
    a couple more days.

    @ezio-melotti
    Copy link
    Member

    Ping?

    @rhettinger
    Copy link
    Contributor Author

    I've long since lost interest in this.
    If anyone wants to push it forward,
    feel free to re-open.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 14, 2013

    New changeset 4678259af5a4 by Georg Brandl in branch '2.7':
    The Integral class does not contain implementations for the bit-shifting operations. (See bpo-3056.)
    http://hg.python.org/cpython/rev/4678259af5a4

    New changeset 1d4ba14cc505 by Georg Brandl in branch '3.3':
    The Integral class does not contain implementations for the bit-shifting operations. (See bpo-3056.)
    http://hg.python.org/cpython/rev/1d4ba14cc505

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @rhettinger @gvanrossum @ezio-melotti