Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distutils._msvccompiler cannot find VS 2017 #74574

Closed
zooba opened this issue May 17, 2017 · 7 comments
Closed

distutils._msvccompiler cannot find VS 2017 #74574

zooba opened this issue May 17, 2017 · 7 comments
Assignees
@zooba
Labels
3.7 (EOL) end of life OS-windows stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@zooba
Copy link
Member

zooba commented May 17, 2017

BPO 30389
Nosy @pfmoore, @vstinner, @tjguk, @merwok, @zware, @zooba, @dstufft
PRs
  • bpo-30389 Adds detection of VS 2017 #1632
  • [3.6] bpo-30389 Adds detection of VS 2017 to distutils._msvccompiler GH-1632 #3425
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2017-09-11.15:53:48.951>
created_at = <Date 2017-05-17.17:54:52.483>
labels = ['3.7', 'type-bug', 'library', 'OS-windows']
title = 'distutils._msvccompiler cannot find VS 2017'
updated_at = <Date 2017-09-11.17:23:05.940>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2017-09-11.17:23:05.940>
actor = 'vstinner'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2017-09-11.15:53:48.951>
closer = 'steve.dower'
components = ['Distutils', 'Windows']
creation = <Date 2017-05-17.17:54:52.483>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 30389
keywords = []
message_count = 7.0
messages = ['293862', '301612', '301632', '301676', '301704', '301881', '301892']
nosy_count = 7.0
nosy_names = ['paul.moore', 'vstinner', 'tim.golden', 'eric.araujo', 'zach.ware', 'steve.dower', 'dstufft']
pr_nums = ['1632', '3425']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue30389'
versions = ['Python 3.6', 'Python 3.7']
    @zooba
    Copy link
    Member Author

    zooba commented May 17, 2017

    Visual Studio 2017 (including VC 14.1) cannot be discovered by the old registry key method. There is a new method that requires instantiating a COM class and querying for all installs, then selecting one.

    My pyfindvs library (https://github.com/zooba/pyfindvs) can find a VS 2017 installation, and I propose porting the core C function into Python so that distutils._msvccompiler can use it.

    This would be internal and not for public use (except via the normal build_ext API).

    @zooba zooba added the 3.7 (EOL) end of life label May 17, 2017
    @zooba zooba self-assigned this May 17, 2017
    @zooba zooba added stdlib Python modules in the Lib dir OS-windows type-bug An unexpected behavior, bug, or error labels May 17, 2017
    @zooba
    Copy link
    Member Author

    zooba commented Sep 7, 2017

    New changeset 05f01d8 by Steve Dower in branch 'master':
    bpo-30389 Adds detection of VS 2017 to distutils._msvccompiler (bpo-1632)
    05f01d8

    @zooba
    Copy link
    Member Author

    zooba commented Sep 7, 2017

    New changeset 76006f2 by Steve Dower in branch '3.6':
    [3.6] bpo-30389 Adds detection of VS 2017 to distutils._msvccompiler #45973 (bpo-3425)
    76006f2

    @vstinner
    Copy link
    Member

    vstinner commented Sep 8, 2017

    I'm pretty sure that the commit 05f01d8 introduced this memory leak:

    test_distutils leaked [8736, 8740, 8740] references, sum=26216
    test_distutils leaked [8640, 8642, 8642] memory blocks, sum=25924

    http://buildbot.python.org/all/builders/AMD64%20Windows8.1%20Refleaks%203.x/builds/99/steps/test/logs/stdio

    @vstinner
    Copy link
    Member

    vstinner commented Sep 8, 2017

    Python 3.6 is also impacted:
    http://buildbot.python.org/all/builders/AMD64%20Windows8.1%20Refleaks%203.6/builds/104

    @zooba
    Copy link
    Member Author

    zooba commented Sep 11, 2017

    I fixed the ref leak during the sprints but forgot to tag this issue in the PR.

    @zooba zooba closed this as completed Sep 11, 2017
    @vstinner
    Copy link
    Member

    The fix:

    commit af8d6b9
    Author: Steve Dower <steve.dower@microsoft.com>
    Date: Fri Sep 8 11:35:38 2017 -0700

    Fixes reference leak (bpo-3457)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.7 (EOL) end of life OS-windows stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @zooba