Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Python/thread_foobar.h #74465

Closed
ma8ma mannequin opened this issue May 5, 2017 · 4 comments
Closed

Remove unused Python/thread_foobar.h #74465

ma8ma mannequin opened this issue May 5, 2017 · 4 comments
Labels
3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@ma8ma
Copy link
Mannequin

ma8ma mannequin commented May 5, 2017

BPO 30279
Nosy @vstinner, @ma8ma
PRs
  • bpo-30279: Remove unused Python/thread_foobar.h #1473
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-05-05.08:09:04.270>
created_at = <Date 2017-05-05.07:39:25.283>
labels = ['interpreter-core', 'type-feature', '3.7']
title = 'Remove unused Python/thread_foobar.h'
updated_at = <Date 2017-05-05.08:09:04.268>
user = 'https://github.com/ma8ma'

    bugs.python.org fields:

    activity = <Date 2017-05-05.08:09:04.268>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2017-05-05.08:09:04.270>
closer = 'vstinner'
components = ['Interpreter Core']
creation = <Date 2017-05-05.07:39:25.283>
creator = 'masamoto'
dependencies = []
files = []
hgrepos = []
issue_num = 30279
keywords = []
message_count = 4.0
messages = ['293057', '293065', '293067', '293070']
nosy_count = 2.0
nosy_names = ['vstinner', 'masamoto']
pr_nums = ['1473']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue30279'
versions = ['Python 3.7']
    @ma8ma
    Copy link
    Mannequin Author

    ma8ma mannequin commented May 5, 2017

    Python/thread_foobar.h is the template code that is threading adaptation for new platforms, and it hasn't been used on actual platforms. As a matter of fact, Python/thread_pthread.h and Python/thread_nt.h give concrete examples of adaptation, therefore, I think thread_foobar.h hasn't needed no more. In addition, there was an issue that only changed thread_foobar.h to fix overlooking (bpo-21312).

    python-dev: https://mail.python.org/pipermail/python-dev/2017-May/147840.html

    @ma8ma ma8ma mannequin added 3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels May 5, 2017
    @vstinner
    Copy link
    Member

    vstinner commented May 5, 2017

    Copy of my answer on the python-dev thread:

    You can remove thread_foobar.h. I don't think that anyone still wants
    to use this template. The other thread_*.h files can be used as
    template as well.

    Victor

    @vstinner
    Copy link
    Member

    vstinner commented May 5, 2017

    New changeset fdaeea6 by Victor Stinner (Masayuki Yamamoto) in branch 'master':
    bpo-30279: Remove unused Python/thread_foobar.h (bpo-1473)
    fdaeea6

    @vstinner
    Copy link
    Member

    vstinner commented May 5, 2017

    I hope that your merged change will now make your work simpler ;-) I don't want to backport this change, so I close the issue.

    @vstinner vstinner closed this as completed May 5, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vstinner