Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve struct.unpack_from's error message like struct.pack_into #74435

Closed
zhangyangyu opened this issue May 3, 2017 · 2 comments
Closed

improve struct.unpack_from's error message like struct.pack_into #74435

zhangyangyu opened this issue May 3, 2017 · 2 comments
Assignees
@zhangyangyu
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@zhangyangyu
Copy link
Member

BPO 30249
Nosy @zhangyangyu
PRs
  • bpo-30249: Improve struct.unpack_from() error messages #6059
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zhangyangyu'
closed_at = <Date 2018-03-10.19:00:24.770>
created_at = <Date 2017-05-03.08:55:20.067>
labels = ['3.8', 'type-feature', 'library']
title = "improve struct.unpack_from's error message like struct.pack_into"
updated_at = <Date 2018-03-10.19:00:24.769>
user = 'https://github.com/zhangyangyu'

    bugs.python.org fields:

    activity = <Date 2018-03-10.19:00:24.769>
actor = 'xiang.zhang'
assignee = 'xiang.zhang'
closed = True
closed_date = <Date 2018-03-10.19:00:24.770>
closer = 'xiang.zhang'
components = ['Library (Lib)']
creation = <Date 2017-05-03.08:55:20.067>
creator = 'xiang.zhang'
dependencies = []
files = []
hgrepos = []
issue_num = 30249
keywords = ['patch']
message_count = 2.0
messages = ['292862', '313554']
nosy_count = 1.0
nosy_names = ['xiang.zhang']
pr_nums = ['6059']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue30249'
versions = ['Python 3.8']
    @zhangyangyu
    Copy link
    Member Author

    In bpo-29649, the error message of struct.pack_into was improved. Since pack_into was changed, I think it's also worth improving unpack_from.

    @zhangyangyu zhangyangyu added 3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels May 3, 2017
    @zhangyangyu zhangyangyu added 3.8 only security fixes and removed 3.7 (EOL) end of life labels Mar 10, 2018
    @zhangyangyu zhangyangyu self-assigned this Mar 10, 2018
    @zhangyangyu
    Copy link
    Member Author

    New changeset c10b288 by Xiang Zhang in branch 'master':
    bpo-30249: Improve struct.unpack_from() error messages (GH-6059)
    c10b288

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zhangyangyu zhangyangyu

    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @zhangyangyu