Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use add_mutually_exclusive_group(required=True) in zipfile and tarfile CLI #74144

Closed
serhiy-storchaka opened this issue Apr 1, 2017 · 2 comments
Closed

Use add_mutually_exclusive_group(required=True) in zipfile and tarfile CLI #74144

serhiy-storchaka opened this issue Apr 1, 2017 · 2 comments
Assignees
@serhiy-storchaka
Labels
3.7 (EOL) end of life type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 29958
Nosy @serhiy-storchaka
PRs
  • bpo-29958: Minor improvements to zipfile and tarfile CLI. #944
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2017-04-07.15:56:35.469>
created_at = <Date 2017-04-01.06:38:51.286>
labels = ['type-feature', '3.7']
title = 'Use add_mutually_exclusive_group(required=True) in zipfile and tarfile CLI'
updated_at = <Date 2017-04-07.15:56:35.469>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2017-04-07.15:56:35.469>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2017-04-07.15:56:35.469>
closer = 'serhiy.storchaka'
components = ['Demos and Tools']
creation = <Date 2017-04-01.06:38:51.286>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 29958
keywords = []
message_count = 2.0
messages = ['290966', '291276']
nosy_count = 2.0
nosy_names = ['SilentGhost', 'serhiy.storchaka']
pr_nums = ['944']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue29958'
versions = ['Python 3.7']
    @serhiy-storchaka
    Copy link
    Member Author

    In the comment to the patch on bpo-28115 SilentGhost suggested to pass required=True to add_mutually_exclusive_group(). This makes the last "else" not needed.

    Proposed patch implements this idea for zipfile and tarfile. It also improves error handling when pass empty tar archive name, and adds a hyphen in "command-line".

    @serhiy-storchaka serhiy-storchaka added the 3.7 (EOL) end of life label Apr 1, 2017
    @serhiy-storchaka serhiy-storchaka self-assigned this Apr 1, 2017
    @serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Apr 1, 2017
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 150cd19 by Serhiy Storchaka in branch 'master':
    bpo-29958: Minor improvements to zipfile and tarfile CLI. (#944)
    150cd19

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    3.7 (EOL) end of life type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @serhiy-storchaka