Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ttk support for Tkinter #47232

Closed
gpolo mannequin opened this issue May 27, 2008 · 13 comments
Closed

Ttk support for Tkinter #47232

gpolo mannequin opened this issue May 27, 2008 · 13 comments
Labels
topic-tkinter

Comments

@gpolo
Copy link
Mannequin

gpolo mannequin commented May 27, 2008

BPO 2983
Nosy @brettcannon, @merwok

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2009-01-28.16:16:40.757>
created_at = <Date 2008-05-27.17:57:08.841>
labels = ['expert-tkinter']
title = 'Ttk support for Tkinter'
updated_at = <Date 2011-06-19.19:57:25.537>
user = 'https://bugs.python.org/gpolo'

bugs.python.org fields:

activity = <Date 2011-06-19.19:57:25.537>
actor = 'eric.araujo'
assignee = 'none'
closed = True
closed_date = <Date 2009-01-28.16:16:40.757>
closer = 'gpolo'
components = ['Tkinter']
creation = <Date 2008-05-27.17:57:08.841>
creator = 'gpolo'
dependencies = []
files = []
hgrepos = []
issue_num = 2983
keywords = []
message_count = 13.0
messages = ['67419', '70200', '70919', '75163', '75170', '79018', '79019', '79021', '79022', '80707', '80712', '80716', '138657']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'wordtech', 'gpolo', 'eric.araujo']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue2983'
versions = ['Python 3.1', 'Python 2.7']
@gpolo
Copy link
Mannequin Author

gpolo mannequin commented May 27, 2008

Hello, this issue could be considered an extension of bpo-2618 and
maybe I should have continued there but.. continuing,

I'm proposing the inclusion of a ttk module (should be renamed to Ttk
for python 2.x) that would fit inside lib-tk or the new tkinter package.
This is a wrapper for the new themed widget set included with Tk 8.5,
which will also work if you have the tile package installed and an older
Tk version (I tested with Tk 8.4 only).

The code and docs are at:
http://svn.python.org/view/sandbox/trunk/ttk-gsoc/

@gpolo gpolo mannequin added the topic-tkinter label May 27, 2008
@gpolo
Copy link
Mannequin Author

gpolo mannequin commented Jul 24, 2008

I've added it to PyPi (http://pypi.python.org/pypi/pyttk) yesterday to
facilitate the process of installing the module (without needing to
checkout the repo) in the hope that people will use it, and contribute
to make it better and possibly even support its inclusion into python
(given the chances of getting this into 2.6 and 3.0 are near zero now).

@brettcannon
Copy link
Member

I wish I had realized this work was done or else I would have pushed to
get this in for 2.6/3.0. Damn. Setting for 2.7/3.1, although if the
decision was made it was easier to only have it in 3.1 that would be
fine by me.

Regardless, setting this to high since while it is not a bug fix, being
able to make Tk apps that aren't quite so ugly would be REALLY nice and
might re-invigorate use of tkinter.

@gpolo
Copy link
Mannequin Author

gpolo mannequin commented Oct 24, 2008

Now that the new branches are around I guess we could consider adding it
then ? I will help with anything.

@brettcannon
Copy link
Member

On Fri, Oct 24, 2008 at 5:27 AM, Guilherme Polo <report@bugs.python.org> wrote:

Guilherme Polo <ggpolo@gmail.com> added the comment:

Now that the new branches are around I guess we could consider adding it
then ? I will help with anything.

Yes, we can consider adding this now.

@brettcannon
Copy link
Member

Do you still need a review for this, Guilherme? If you just need a quick
code check I can see if I can make the time for this, but my tkinter
knowledge is lacking so it won't be very in-depth. Hopefully this is all
isolated enough that even if it is initially broken it won't be a big
deal if you just check it in.

And do you want this in 2.7 and 3.1, or out of simplicity just 3.1?

@gpolo
Copy link
Mannequin Author

gpolo mannequin commented Jan 3, 2009

Do you still need a review for this, Guilherme? If you just need a quick
code check I can see if I can make the time for this, but my tkinter
knowledge is lacking so it won't be very in-depth. Hopefully this is all
isolated enough that even if it is initially broken it won't be a big
deal if you just check it in.

I was waiting more for an "Ok, commit" as I though Fredrik already did
a quick code check on it.
But of course you can look at it too if you want.

Also, would it be fine to leave its tests on lib-tk (2.7) and tkinter (3.1) ?

And do you want this in 2.7 and 3.1, or out of simplicity just 3.1?

I would like both if I can decide on that.

@brettcannon
Copy link
Member

If Fredrik already reviewed it I don't see why you can't commit. If
something goes wrong you can always back the commit out.

As for the testing question, I am not sure I understand what you are
asking. Are you asking if the tests can stay integrated with tkinter's
existing tests?

Ans as for versions, put it into whatever versions you want to support.
I was just saying you can do 3.1 only if you don't want to the hassle of
supporting both versions. If you are up for it then please do both!

@gpolo
Copy link
Mannequin Author

gpolo mannequin commented Jan 3, 2009

As for the testing question, I am not sure I understand what you are
asking. Are you asking if the tests can stay integrated with tkinter's
existing tests?

There are no tests for tkinter, except for some few ones for _tkinter
basic functionality living on Lib/test/test_tcl.py
If it is ok I can start a test/ directory inside lib-tk and tkinter
(py3k), I would then prefix ttk file tests with a "ttk".

Ans as for versions, put it into whatever versions you want to support.
I was just saying you can do 3.1 only if you don't want to the hassle of
supporting both versions. If you are up for it then please do both!

Perfect, both then :)

@gpolo
Copy link
Mannequin Author

gpolo mannequin commented Jan 28, 2009

Added in python-trunk now: r69050

I will be merging it into py3k now, and my bad for taking so long to do
this.

@gpolo
Copy link
Mannequin Author

gpolo mannequin commented Jan 28, 2009

r69051 in py3k

Now only samples are missing, I will be doing these later today I think.
And there is an issue regarding regrtest (gui resource), see bpo-5083.

@gpolo
Copy link
Mannequin Author

gpolo mannequin commented Jan 28, 2009

samples: r69053 and r69055

Closing the issue now, thanks.

@gpolo gpolo mannequin closed this as completed Jan 28, 2009
@merwok
Copy link
Member

merwok commented Jun 19, 2011

The 2.7 docs are missing a versionadded directive.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-tkinter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @merwok