Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed reference to create_module() in versionadded (import.rst) #73834

Closed
marco-buttu mannequin opened this issue Feb 25, 2017 · 7 comments
Closed

Missed reference to create_module() in versionadded (import.rst) #73834

marco-buttu mannequin opened this issue Feb 25, 2017 · 7 comments
Labels
3.7 (EOL) end of life docs Documentation in the Doc dir

Comments

@marco-buttu
Copy link
Mannequin

marco-buttu mannequin commented Feb 25, 2017

BPO 29648
Nosy @brettcannon, @ncoghlan, @ericsnowcurrently, @marco-buttu, @Mariatta
PRs
  • bpo-26184: import.rst: Add versionchanged note #277
  • bpo-29648: Add reference to create_module() #290
  • [3.6] bpo-29648: import.rst: Add reference to create_module() (GH-290) #314
  • [3.5] bpo-29648: import.rst: Add reference to create_module() (GH-290) #315
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-02-26.15:41:55.679>
created_at = <Date 2017-02-25.11:22:08.905>
labels = ['3.7', 'docs']
title = 'Missed reference to create_module() in versionadded (import.rst)'
updated_at = <Date 2017-03-24.23:42:22.346>
user = 'https://github.com/marco-buttu'

    bugs.python.org fields:

    activity = <Date 2017-03-24.23:42:22.346>
actor = 'Mariatta'
assignee = 'docs@python'
closed = True
closed_date = <Date 2017-02-26.15:41:55.679>
closer = 'Mariatta'
components = ['Documentation']
creation = <Date 2017-02-25.11:22:08.905>
creator = 'marco.buttu'
dependencies = []
files = []
hgrepos = []
issue_num = 29648
keywords = []
message_count = 7.0
messages = ['288560', '288572', '288596', '288597', '290385', '290387', '290392']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'ncoghlan', 'docs@python', 'eric.snow', 'marco.buttu', 'Mariatta']
pr_nums = ['277', '290', '314', '315']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue29648'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']
    @marco-buttu
    Copy link
    Mannequin Author

    marco-buttu mannequin commented Feb 25, 2017

    In the first versionadded of the Loader section [1] of Doc/reference/import.rst, there is no reference to create_module():

    .. versionadded:: 3.4
    The create_module() method of loaders.

    It should be:

    .. versionadded:: 3.4
    The :meth:`~importlib.abc.Loader.create_module` method of loaders.

    I will make a PR.

    [1] https://docs.python.org/3/reference/import.html#loaders

    @marco-buttu marco-buttu mannequin added the 3.7 (EOL) end of life label Feb 25, 2017
    @Mariatta
    Copy link
    Member

    Thanks, Marco. Your change looks good to me.
    I'm now wondering if this should have been 'versionchanged' instead of 'versionadded'. Perhaps other core devs can confirm this.

    Thanks :)

    @Mariatta Mariatta added the docs Documentation in the Doc dir label Feb 25, 2017
    @ncoghlan
    Copy link
    Contributor

    Version added is correct here, as the "create_module()" methods are all new in 3.4, and the traditional granularity for deciding "addition or change?" is that new functions, methods, and attributes are always additions, even if they're being added to a class definition.

    @Mariatta
    Copy link
    Member

    Thanks for the clarification, Nick :)

    Marco, I merged your PR, and backported to 3.5 and 3.6 branches.
    Thanks!

    @Mariatta
    Copy link
    Member

    New changeset 63ed9bc by Mariatta in branch '3.5':
    bpo-29648: import.rst: Add reference to create_module() (GH-290) (GH-315)
    63ed9bc

    @Mariatta
    Copy link
    Member

    New changeset 7333d17 by Mariatta in branch '3.6':
    bpo-29648: import.rst: Add reference to create_module() (GH-290) (GH-314)
    7333d17

    @Mariatta
    Copy link
    Member

    New changeset 46ce759 by Mariatta (Marco Buttu) in branch 'master':
    bpo-29648: import.rst: Add reference to create_module() (GH-290)
    46ce759

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life docs Documentation in the Doc dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @ncoghlan @Mariatta