Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken stack_effect for CALL_FUNCTION_EX #73793

Closed
MatthieuDartiailh mannequin opened this issue Feb 20, 2017 · 6 comments
Closed

Broken stack_effect for CALL_FUNCTION_EX #73793

MatthieuDartiailh mannequin opened this issue Feb 20, 2017 · 6 comments
Assignees
@serhiy-storchaka
Labels
3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@MatthieuDartiailh
Copy link
Mannequin

MatthieuDartiailh mannequin commented Feb 20, 2017

BPO 29607
Nosy @methane, @serhiy-storchaka, @serprex, @MatthieuDartiailh
PRs
  • bpo-29607: Fix stack_effect computation for CALL_FUNCTION_EX #202
  • [3.6] bpo-29607: Fix stack_effect computation for CALL_FUNCTION_EX #219
  • [Do Not Merge] Sample of CPython life with blurb. #703
  • [Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2017-02-21.17:34:36.718>
created_at = <Date 2017-02-20.19:50:39.357>
labels = ['interpreter-core', 'type-bug', '3.7']
title = 'Broken stack_effect for CALL_FUNCTION_EX'
updated_at = <Date 2017-03-31.16:36:13.277>
user = 'https://github.com/MatthieuDartiailh'

    bugs.python.org fields:

    activity = <Date 2017-03-31.16:36:13.277>
actor = 'dstufft'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2017-02-21.17:34:36.718>
closer = 'methane'
components = ['Interpreter Core']
creation = <Date 2017-02-20.19:50:39.357>
creator = 'mdartiailh'
dependencies = []
files = []
hgrepos = []
issue_num = 29607
keywords = []
message_count = 6.0
messages = ['288230', '288232', '288292', '288297', '288311', '288312']
nosy_count = 4.0
nosy_names = ['methane', 'serhiy.storchaka', 'Demur Rumed', 'mdartiailh']
pr_nums = ['202', '219', '703', '552']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue29607'
versions = ['Python 3.6', 'Python 3.7']
    @MatthieuDartiailh
    Copy link
    Mannequin Author

    MatthieuDartiailh mannequin commented Feb 20, 2017

    The computation of the stack_effect of the CALL_FUNCTION_EX does not reflect the use of the argument to the opcode.

    Currently stack_effect expect two flags (one on 0x01 and one on 0x02) corresponding to whether positional arguments and keyword arguments are being passed. However in the current implementation the argument of CALL_FUNCTION_EX is either 0 or 1 depending on the presence of keyword arguments. According to Serhiy Storchaka, the behavior of stack_effect is a left-over of the previous implementation and should be fixed.

    @MatthieuDartiailh MatthieuDartiailh mannequin added 3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Feb 20, 2017
    @serhiy-storchaka
    Copy link
    Member

    The fix LGTM. Please add the Misc/NEWS entry.

    @serhiy-storchaka serhiy-storchaka self-assigned this Feb 20, 2017
    @MatthieuDartiailh
    Copy link
    Mannequin Author

    MatthieuDartiailh mannequin commented Feb 21, 2017

    I added the Misc/NEWS entry under Python 3.7. I guess it will be backported to 3.6 when cherry-pinking.

    @serhiy-storchaka
    Copy link
    Member

    New changeset 3a9ac82 by Serhiy Storchaka in branch 'master':
    bpo-29607: Fix stack_effect computation for CALL_FUNCTION_EX (#202)
    3a9ac82

    @methane
    Copy link
    Member

    methane commented Feb 21, 2017

    New changeset 3ab24bd by GitHub in branch '3.6':
    bpo-29607: Fix stack_effect computation for CALL_FUNCTION_EX (GH-219)
    3ab24bd

    @methane
    Copy link
    Member

    methane commented Feb 21, 2017

    Thanks, Matthieu.

    @methane methane closed this as completed Feb 21, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @methane @serhiy-storchaka