Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bdist_rpm does not list dist files (should effect upload) #47194

Closed
htgoebel mannequin opened this issue May 22, 2008 · 13 comments
Closed

bdist_rpm does not list dist files (should effect upload) #47194

htgoebel mannequin opened this issue May 22, 2008 · 13 comments
Assignees
@merwok
Labels
easy stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@htgoebel
Copy link
Mannequin

htgoebel mannequin commented May 22, 2008

BPO 2945
Nosy @tarekziade, @merwok
Files
  • simple-0.0.0.0.1.tar.gz: simple package to show the bug
  • bdist_rpm.patch: bdist_rpm patch
  • test_bdist_rpm.patch: patch for test_bdist_rpm.py
  • bdist_rpm-2.7.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/merwok'
closed_at = <Date 2012-02-26.03:12:53.945>
created_at = <Date 2008-05-22.14:34:30.366>
labels = ['easy', 'type-bug', 'library']
title = 'bdist_rpm does not list dist files (should effect upload)'
updated_at = <Date 2012-02-26.03:12:53.943>
user = 'https://bugs.python.org/htgoebel'

    bugs.python.org fields:

    activity = <Date 2012-02-26.03:12:53.943>
actor = 'eric.araujo'
assignee = 'eric.araujo'
closed = True
closed_date = <Date 2012-02-26.03:12:53.945>
closer = 'eric.araujo'
components = ['Distutils']
creation = <Date 2008-05-22.14:34:30.366>
creator = 'htgoebel'
dependencies = []
files = ['10403', '23333', '23363', '23364']
hgrepos = []
issue_num = 2945
keywords = ['patch', 'easy']
message_count = 13.0
messages = ['67192', '112432', '143221', '145045', '145092', '145292', '145293', '145305', '145333', '152516', '152685', '154296', '154305']
nosy_count = 5.0
nosy_names = ['htgoebel', 'tarek', 'eric.araujo', 'python-dev', 'crobben']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue2945'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']
    @htgoebel
    Copy link
    Mannequin Author

    htgoebel mannequin commented May 22, 2008

    In Python 2.5 distutils has a bug in bdist_rpm:

    Generated distribution files are not listed in
    distribution.dist_files. Thus .rpms can not be handled by other
    tools, eg. upload.

    I need this bug fixed for automated upload of files using
    <http://origo-submit.origo.ethz.ch\>.

    Enclosed please find a simple package to show the bug. Just run

    python setup.py bdist_rpm

    and watch the (missing) output. In contrast see the output of

    python setup.py sdist

    Additionally:
    While untested, this should effect distutils upload command. RPMs
    are not in the dist_files list and when looking at the source, there
    seams to be no 'trick' to add them later.

    @htgoebel htgoebel mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels May 22, 2008
    @tarekziade tarekziade mannequin self-assigned this Feb 6, 2009
    @merwok
    Copy link
    Member

    merwok commented Aug 2, 2010

    Tarek, can this bug be fixed or is it outdated? IOW, is bdist_rpm officially discouraged or do you still accept bugfixes for it?

    @merwok
    Copy link
    Member

    merwok commented Aug 30, 2011

    Even thought bdist_rpm is gone from distutils2, this is a bug that can be fixed in distutils. Adding the easy keyword to let potential contributors find this bug; hint: look at how bdist_dumb registers distributions with dist.dist_files.

    @merwok merwok added the easy label Aug 30, 2011
    @crobben
    Copy link
    Mannequin

    crobben mannequin commented Oct 6, 2011

    I found that bdist_rpm wasn't registering distributions with dist.dist_files at all. The attached patch should be all that's needed to fix this.

    @merwok
    Copy link
    Member

    merwok commented Oct 7, 2011

    Great! Could you add a test for this? By the way, do you have a machine with rpm installed? I don’t, so I won’t be able to test the patch.

    @crobben
    Copy link
    Mannequin

    crobben mannequin commented Oct 10, 2011

    Here's a patch for test_bdist_rpm.py and to check the contents of dist.dist_files

    @crobben
    Copy link
    Mannequin

    crobben mannequin commented Oct 10, 2011

    Adding a patch for 2.7

    @merwok
    Copy link
    Member

    merwok commented Oct 10, 2011

    Looks good. Do you have rpm on your machine? If yes, have you run the tests successfully?

    @crobben
    Copy link
    Mannequin

    crobben mannequin commented Oct 11, 2011

    Yeah I installed rpm and have run the tests successfully.

    @merwok
    Copy link
    Member

    merwok commented Feb 3, 2012

    FYI I have committed the patch to my repo and will push as soon as I can.

    @merwok merwok assigned merwok and unassigned tarekziade Feb 3, 2012
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 5, 2012

    New changeset 26aea1825418 by Éric Araujo in branch '3.2':
    Stop ignoring RPMs in distutils' upload command (bpo-2945).
    http://hg.python.org/cpython/rev/26aea1825418

    New changeset 1cb9b8126534 by Éric Araujo in branch 'default':
    Merge edits from 3.2 (bpo-13716, bpo-1040439, bpo-2945, bpo-13770, bpo-6715)
    http://hg.python.org/cpython/rev/1cb9b8126534

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 26, 2012

    New changeset f606d722ca23 by Éric Araujo in branch '2.7':
    Stop ignoring RPMs in distutils' upload command (bpo-2945).
    http://hg.python.org/cpython/rev/f606d722ca23

    @merwok
    Copy link
    Member

    merwok commented Feb 26, 2012

    Fixed in 2.7 too, thanks to you both. If you have the time to run the tests, it would be great to get a confirmation (I’m not sure we have a buildbot with rpm installed for 2.7).

    @merwok merwok closed this as completed Feb 26, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @merwok merwok

    Labels
    easy stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @merwok