Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE search and replace should use 'hit' tag instead of 'hilite' #73568

Open
ds2 mannequin opened this issue Jan 28, 2017 · 3 comments
Open

IDLE search and replace should use 'hit' tag instead of 'hilite' #73568

ds2 mannequin opened this issue Jan 28, 2017 · 3 comments
Assignees
@terryjreedy
Labels
3.10 only security fixes topic-IDLE type-feature A feature request or enhancement

Comments

@ds2
Copy link
Mannequin

ds2 mannequin commented Jan 28, 2017

BPO 29382
Nosy @terryjreedy

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = None
created_at = <Date 2017-01-28.01:03:15.392>
labels = ['expert-IDLE', 'type-feature', '3.10']
title = "IDLE search and replace should use 'hit' tag instead of 'hilite'"
updated_at = <Date 2020-06-06.22:09:25.323>
user = 'https://bugs.python.org/ds2'

bugs.python.org fields:

activity = <Date 2020-06-06.22:09:25.323>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = False
closed_date = None
closer = None
components = ['IDLE']
creation = <Date 2017-01-28.01:03:15.392>
creator = 'd s2'
dependencies = []
files = []
hgrepos = []
issue_num = 29382
keywords = []
message_count = 3.0
messages = ['286393', '286395', '286397']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'd s2']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue29382'
versions = ['Python 3.10']
@ds2
Copy link
Mannequin Author

ds2 mannequin commented Jan 28, 2017

Searching for this issue turned up a bunch of results claiming it's fixed, but it isn't, at least not on my windows 10 machine. I tried replacing 'hit' with 'itdunwork' in colorizer.py, searchbase.py, replace.py, searchengine.py, config.py, search.py, configdialog.py, and of course config-highlight.cfg, but it didn't work.

@ds2 ds2 mannequin added type-bug An unexpected behavior, bug, or error OS-windows labels Jan 28, 2017
@ds2 ds2 mannequin assigned terryjreedy Jan 28, 2017
@ds2 ds2 mannequin added the topic-IDLE label Jan 28, 2017
@terryjreedy
Copy link
Member

The now-closed issues I remember were about hits not being visibly marked at all. For me, on Win 10 with 3.6, they are being marked. If you are referring to any discussion specifically about which tag to use, please post the issue numbers prefixed with '#', as in bpo-29382, to make them become links.

Without a patch and more explanaton, I am not sure what you did and what you saw as a result.

I have considered changing the 'hit' tag, but I want to first investigate the behave of other editors (and apps with 'find' functions) on the major platforms. When I have a proposed patch, I will solicit opinions on whether it is better.

@terryjreedy terryjreedy added 3.7 (EOL) end of life and removed OS-windows labels Jan 28, 2017
@terryjreedy terryjreedy changed the title IDLE search/replace/replace+find is (still?) using the 'hilite' tag instead of 'hit' IDLE search and replace should use 'hit' tag instead of 'hilite' Jan 28, 2017
@terryjreedy terryjreedy added type-feature A feature request or enhancement and removed type-bug An unexpected behavior, bug, or error labels Jan 28, 2017
@terryjreedy
Copy link
Member

After the original bug for bpo-18590 was fixed, I left it open for working on the tags. (Currently, Find and the find part of Replace work differently and at least one of them double tags found text.) I decided to close it and use this for the tag choice issue.

My replace_find_hit.diff patch on bpo-18590 should be considered transferred to this one.

@terryjreedy terryjreedy added 3.10 only security fixes and removed 3.7 (EOL) end of life labels Jun 6, 2020
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terryjreedy terryjreedy

Labels
3.10 only security fixes topic-IDLE type-feature A feature request or enhancement
Projects
IDLE Issues
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terryjreedy