Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite3 Controlling Transactions documentation not updated #73307

Closed
palaviv mannequin opened this issue Dec 31, 2016 · 7 comments
Closed

sqlite3 Controlling Transactions documentation not updated #73307

palaviv mannequin opened this issue Dec 31, 2016 · 7 comments
Labels
3.7 (EOL) end of life docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@palaviv
Copy link
Mannequin

palaviv mannequin commented Dec 31, 2016

BPO 29121
Nosy @berkerpeksag, @serhiy-storchaka, @animalize, @palaviv
PRs
  • bpo-29121: Remove outdated documentation about transactions #313
  • [3.6] bpo-29121: Remove outdated documentation about transactions (#313) #319
    		•
    Files
  • sqlite-transaction-doc.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-02-26.16:04:48.886>
created_at = <Date 2016-12-31.16:04:55.057>
labels = ['type-bug', '3.7', 'docs']
title = 'sqlite3 Controlling Transactions documentation not updated'
updated_at = <Date 2017-03-24.23:41:51.182>
user = 'https://github.com/palaviv'

    bugs.python.org fields:

    activity = <Date 2017-03-24.23:41:51.182>
actor = 'berker.peksag'
assignee = 'docs@python'
closed = True
closed_date = <Date 2017-02-26.16:04:48.886>
closer = 'berker.peksag'
components = ['Documentation']
creation = <Date 2016-12-31.16:04:55.057>
creator = 'palaviv'
dependencies = []
files = ['46101']
hgrepos = []
issue_num = 29121
keywords = ['patch']
message_count = 7.0
messages = ['284396', '286217', '286293', '288598', '290379', '290388', '290389']
nosy_count = 6.0
nosy_names = ['ghaering', 'docs@python', 'berker.peksag', 'serhiy.storchaka', 'malin', 'palaviv']
pr_nums = ['313', '319']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue29121'
versions = ['Python 3.6', 'Python 3.7']
    @palaviv
    Copy link
    Mannequin Author

    palaviv mannequin commented Dec 31, 2016

    commit 284676cf2ac8 changed the sqlite3 module so it will no longer implicitly commit an open transaction before DDL statements. The docs have been updated but there is still an incorrect paragraph that has not been removed.
    Attached is a patch that remove the old paragraph.

    @palaviv palaviv mannequin added the 3.7 (EOL) end of life label Dec 31, 2016
    @palaviv
    Copy link
    Mannequin Author

    palaviv mannequin commented Jan 24, 2017

    I would just like to note that I think that the correct solution is to do an implicit commit before:

    1. VACUUM
    2. ATTACH
    3. DETACH
    4. BEGIN

    @animalize
    Copy link
    Mannequin

    animalize mannequin commented Jan 26, 2017

    After read some issues, there are two major concerns:
    1, backward compatibility.
    2, implicit commit is bad, tolerates bug-prone codes.

    However they are not contradictory if we print a warning when doing an implicit commit. Some messages like this:
    Warning: sqlite3 module issued an implicit commit before executing VACUUM, you should commit this transaction by yourself, that's a good habit, etc..

    Then we can keep backward compatibility, and no longer commit implicitly.

    @berkerpeksag
    Copy link
    Member

    Thanks for the patch, Aviv!

    @berkerpeksag berkerpeksag added the docs Documentation in the Doc dir label Feb 26, 2017
    @berkerpeksag berkerpeksag added the type-bug An unexpected behavior, bug, or error label Feb 26, 2017
    @berkerpeksag
    Copy link
    Member

    New changeset 893e86e by Berker Peksag in branch '3.6':
    bpo-29121: Remove outdated documentation about transactions (#313) (#319)
    893e86e

    @berkerpeksag
    Copy link
    Member

    New changeset fe70d92 by Berker Peksag in branch 'master':
    bpo-29121: Remove outdated documentation about transactions (#313)
    fe70d92

    1 similar comment
    @berkerpeksag
    Copy link
    Member

    New changeset fe70d92 by Berker Peksag in branch 'master':
    bpo-29121: Remove outdated documentation about transactions (#313)
    fe70d92

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @berkerpeksag