Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd PyArg_VaParse to the stable API #73269

Closed
serhiy-storchaka opened this issue Dec 27, 2016 · 3 comments
Closed

Readd PyArg_VaParse to the stable API #73269

serhiy-storchaka opened this issue Dec 27, 2016 · 3 comments
Assignees
Labels
3.7 (EOL) end of life build The build process and cross-build interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@serhiy-storchaka
Copy link
Member

BPO 29083
Nosy @loewis, @serhiy-storchaka
PRs
  • [Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
  • Files
  • PyArg_VaParse-limited-api.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2017-01-25.10:12:03.318>
    created_at = <Date 2016-12-27.13:41:52.484>
    labels = ['interpreter-core', 'build', '3.7']
    title = 'Readd PyArg_VaParse to the stable API'
    updated_at = <Date 2017-03-31.16:36:28.096>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2017-03-31.16:36:28.096>
    actor = 'dstufft'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2017-01-25.10:12:03.318>
    closer = 'serhiy.storchaka'
    components = ['Interpreter Core']
    creation = <Date 2016-12-27.13:41:52.484>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = ['46383']
    hgrepos = []
    issue_num = 29083
    keywords = ['patch']
    message_count = 3.0
    messages = ['284097', '286018', '286209']
    nosy_count = 3.0
    nosy_names = ['loewis', 'python-dev', 'serhiy.storchaka']
    pr_nums = ['552']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue29083'
    versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']

    @serhiy-storchaka
    Copy link
    Member Author

    Seems PyArg_VaParse() and PyArg_VaParseTupleAndKeywords() were excluded from the stable API by the mistake in fixing bpo-11626. These functions was in the stable API before 3.3, and the documentation doesn't mention that they are not in the stable API.

    I think they should be readded to the stable API.

    @serhiy-storchaka serhiy-storchaka added 3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) build The build process and cross-build labels Dec 27, 2016
    @serhiy-storchaka
    Copy link
    Member Author

    There are also issues with PyArg_ValidateKeywordArguments(), PyArg_UnpackTuple() and Py_BuildValue(). Their declarations are not available if define PY_SSIZE_T_CLEAN and Py_LIMITED_API < 3.3. But they were available in Python 3.2.

    Proposed patch fixes these glitches.

    @serhiy-storchaka serhiy-storchaka self-assigned this Jan 22, 2017
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jan 24, 2017

    New changeset 5cdf383ef35c by Serhiy Storchaka in branch '3.5':
    Issue bpo-29083: Fixed the declaration of some public API functions.
    https://hg.python.org/cpython/rev/5cdf383ef35c

    New changeset 8eae65136000 by Serhiy Storchaka in branch '3.6':
    Issue bpo-29083: Fixed the declaration of some public API functions.
    https://hg.python.org/cpython/rev/8eae65136000

    New changeset b63d096403f4 by Serhiy Storchaka in branch 'default':
    Issue bpo-29083: Fixed the declaration of some public API functions.
    https://hg.python.org/cpython/rev/b63d096403f4

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life build The build process and cross-build interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant