Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary hg required for build version 3.6 on Windows #73266

Closed
josephsmeng mannequin opened this issue Dec 27, 2016 · 4 comments
Closed

unnecessary hg required for build version 3.6 on Windows #73266

josephsmeng mannequin opened this issue Dec 27, 2016 · 4 comments
Assignees
@zooba
Labels
3.7 (EOL) end of life build The build process and cross-build OS-windows

Comments

@josephsmeng
Copy link
Mannequin

josephsmeng mannequin commented Dec 27, 2016

BPO 29080
Nosy @pfmoore, @tjguk, @zware, @zooba, @josephsmeng
PRs
  • [Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2016-12-28.22:39:33.793>
created_at = <Date 2016-12-27.09:53:02.808>
labels = ['build', '3.7', 'OS-windows']
title = 'unnecessary hg required for build version 3.6 on Windows'
updated_at = <Date 2017-03-31.16:36:27.629>
user = 'https://github.com/josephsmeng'

    bugs.python.org fields:

    activity = <Date 2017-03-31.16:36:27.629>
actor = 'dstufft'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2016-12-28.22:39:33.793>
closer = 'steve.dower'
components = ['Build', 'Windows']
creation = <Date 2016-12-27.09:53:02.808>
creator = 'josephsmeng'
dependencies = []
files = []
hgrepos = []
issue_num = 29080
keywords = []
message_count = 4.0
messages = ['284078', '284130', '284204', '284212']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'python-dev', 'zach.ware', 'steve.dower', 'josephsmeng']
pr_nums = ['552']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue29080'
versions = ['Python 3.6', 'Python 3.7']
    @josephsmeng
    Copy link
    Mannequin Author

    josephsmeng mannequin commented Dec 27, 2016

    the released 3.6.0 PCbuild/build.bat required hg for building. but this requirement is not necessary for build python from source. maybe it will be better for us to remove this requirement as the old versions.

    @josephsmeng josephsmeng mannequin added type-bug An unexpected behavior, bug, or error build The build process and cross-build labels Dec 27, 2016
    @zooba
    Copy link
    Member

    zooba commented Dec 27, 2016

    You're right. I moved that code from buildrelease.bat, which definitely requires hg.

    PC/build.bat should not fail if hg can't be found. You'll just end up with an empty sys._mercurial/sys.version after building.

    @zooba zooba self-assigned this Dec 27, 2016
    @zooba zooba added 3.7 (EOL) end of life build The build process and cross-build and removed type-bug An unexpected behavior, bug, or error labels Dec 27, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 28, 2016

    New changeset bc71c144e6f0 by Steve Dower in branch '3.5':
    Issue bpo-29080: Removes hard dependency on hg.exe from PC/build.bat
    https://hg.python.org/cpython/rev/bc71c144e6f0

    New changeset f98d8c9f3cde by Steve Dower in branch '3.6':
    Issue bpo-29080: Removes hard dependency on hg.exe from PC/build.bat
    https://hg.python.org/cpython/rev/f98d8c9f3cde

    New changeset 57c2fc60c989 by Steve Dower in branch 'default':
    Issue bpo-29080: Removes hard dependency on hg.exe from PC/build.bat
    https://hg.python.org/cpython/rev/57c2fc60c989

    @zooba zooba closed this as completed Dec 28, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 28, 2016

    New changeset 84beb5cba826 by Steve Dower in branch '3.5':
    Issue bpo-29080: Fixes Misc/NEWS entry
    https://hg.python.org/cpython/rev/84beb5cba826

    New changeset 048d1942b325 by Steve Dower in branch '3.6':
    Issue bpo-29080: Fixes Misc/NEWS entry
    https://hg.python.org/cpython/rev/048d1942b325

    New changeset 38e44a23ea66 by Steve Dower in branch 'default':
    Issue bpo-29080: Fixes Misc/NEWS entry
    https://hg.python.org/cpython/rev/38e44a23ea66

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.7 (EOL) end of life build The build process and cross-build OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @ned-deily