Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify _copy_func_details in unittest.mock #73105

Closed
jiajunhuang mannequin opened this issue Dec 9, 2016 · 6 comments
Closed

Simplify _copy_func_details in unittest.mock #73105

jiajunhuang mannequin opened this issue Dec 9, 2016 · 6 comments
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@jiajunhuang
Copy link
Mannequin

jiajunhuang mannequin commented Dec 9, 2016

BPO 28919
Nosy @voidspace, @berkerpeksag, @jiajunhuang
PRs
  • [backport to 3.6] bpo-27122: Fix comment to point to correct issue number (#47) #48
    		•
    Files
  • mock.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-12-15.02:22:01.212>
created_at = <Date 2016-12-09.10:12:46.606>
labels = ['3.7', 'type-feature', 'library']
title = 'Simplify `_copy_func_details` in unittest.mock'
updated_at = <Date 2016-12-15.02:22:01.211>
user = 'https://github.com/jiajunhuang'

    bugs.python.org fields:

    activity = <Date 2016-12-15.02:22:01.211>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2016-12-15.02:22:01.212>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2016-12-09.10:12:46.606>
creator = 'Jiajun Huang'
dependencies = []
files = ['45811']
hgrepos = []
issue_num = 28919
keywords = ['patch']
message_count = 6.0
messages = ['283046', '283051', '283102', '283109', '283227', '283228']
nosy_count = 4.0
nosy_names = ['michael.foord', 'python-dev', 'berker.peksag', 'Jiajun Huang']
pr_nums = ['48']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue28919'
versions = ['Python 3.7']
    @jiajunhuang jiajunhuang mannequin added 3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Dec 9, 2016
    @berkerpeksag
    Copy link
    Member

    Thanks for the patch. I only did a quick review, but it looks good to me.

    @voidspace
    Copy link
    Contributor

    Yep, looks good to me to.

    @jiajunhuang
    Copy link
    Mannequin Author

    jiajunhuang mannequin commented Dec 13, 2016

    So what should I do next to make the code being merged into CPython? I am new to mercurial(or just wait for it?).

    @berkerpeksag
    Copy link
    Member

    I will commit your patch today if Michael doesn't beat me to it.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 15, 2016

    New changeset bbdfde7958a8 by Berker Peksag in branch 'default':
    Issue bpo-28919: Simplify _copy_func_details() in unittest.mock
    https://hg.python.org/cpython/rev/bbdfde7958a8

    @berkerpeksag
    Copy link
    Member

    Thanks, Jiajun!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @berkerpeksag @voidspace