Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the netrc library #72992

Closed
zhangyangyu opened this issue Nov 26, 2016 · 5 comments
Closed

Improve the netrc library #72992

zhangyangyu opened this issue Nov 26, 2016 · 5 comments
Labels
3.11 bug and security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@zhangyangyu
Copy link
Member

BPO 28806
Nosy @bitdancer, @asvetlov, @zhangyangyu, @eamanu, @tirkarthi
PRs
  • bpo-28806: Improve the netrc library #127
  • bpo-28806: Continue work: improve the netrc library #26330
  • Files
  • netrc.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2016-11-26.11:13:30.329>
    labels = ['type-feature', 'library', '3.11']
    title = 'Improve the netrc library'
    updated_at = <Date 2021-11-17.09:12:58.656>
    user = 'https://github.com/zhangyangyu'

    bugs.python.org fields:

    activity = <Date 2021-11-17.09:12:58.656>
    actor = 'asvetlov'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2016-11-26.11:13:30.329>
    creator = 'xiang.zhang'
    dependencies = []
    files = ['45651']
    hgrepos = []
    issue_num = 28806
    keywords = ['patch']
    message_count = 4.0
    messages = ['281767', '372227', '394254', '406457']
    nosy_count = 5.0
    nosy_names = ['r.david.murray', 'asvetlov', 'xiang.zhang', 'eamanu', 'xtreak']
    pr_nums = ['127', '26330']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue28806'
    versions = ['Python 3.11']

    @zhangyangyu
    Copy link
    Member Author

    netrc library now gets some problems:

    1. All tokens are mandatory. (bpo-28780)
    2. Token values are limited to a limited set of characters. (bpo-557704)
    3. Does not complain about macro definition without a null line.
    4. If the login name is anonymous, security check is not needed.

    Propose a patch to handle these. I treat it as an enhancement of the existing library instead of bug fix.

    @zhangyangyu zhangyangyu added 3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Nov 26, 2016
    @eamanu
    Copy link
    Mannequin

    eamanu mannequin commented Jun 24, 2020

    Hi!

    I let a comment on github. The PR was open 3 years agot, so I was wandering to know if are there some plans with that PR? Are you interested on the PR?

    Cheers,

    @eamanu
    Copy link
    Mannequin

    eamanu mannequin commented May 24, 2021

    Hello everybody I've just make this PR #26330 to continue the work.

    @asvetlov
    Copy link
    Contributor

    New changeset 15409c7 by Emmanuel Arias in branch 'main':
    bpo-28806: Continue work: improve the netrc library (GH-26330)
    15409c7

    @asvetlov asvetlov added 3.11 bug and security fixes and removed 3.7 (EOL) end of life labels Nov 17, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @hauntsaninja
    Copy link
    Contributor

    Thanks, looks like the merged PR addresses this issue

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 bug and security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants