Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python-gdb.py for fastcalls #72956

Closed
vstinner opened this issue Nov 22, 2016 · 10 comments
Closed

Update python-gdb.py for fastcalls #72956

vstinner opened this issue Nov 22, 2016 · 10 comments
Labels
3.7 (EOL) end of life

Comments

@vstinner
Copy link
Member

BPO 28770
Nosy @vstinner, @ned-deily, @methane
Files
  • gdb_fastcall.patch
  • gdb_fastcall-2.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-12-17.05:09:56.782>
created_at = <Date 2016-11-22.11:42:55.134>
labels = ['3.7']
title = 'Update python-gdb.py for fastcalls'
updated_at = <Date 2016-12-17.05:09:56.780>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2016-12-17.05:09:56.780>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2016-12-17.05:09:56.782>
closer = 'ned.deily'
components = []
creation = <Date 2016-11-22.11:42:55.134>
creator = 'vstinner'
dependencies = []
files = ['45598', '45599']
hgrepos = []
issue_num = 28770
keywords = ['patch']
message_count = 10.0
messages = ['281465', '281522', '281523', '282603', '282715', '282716', '283402', '283407', '283464', '283467']
nosy_count = 4.0
nosy_names = ['vstinner', 'ned.deily', 'methane', 'python-dev']
pr_nums = []
priority = None
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue28770'
versions = ['Python 3.6', 'Python 3.7']
    @vstinner
    Copy link
    Member Author

    Python 3.6 has a new C calling convention: "fast calls".

    python-gdb.py was disabled when compact dict was merged, see issue bpo-27350.

    Sadly, I missed that fast calls also broke python-gdb.py.

    Attached patch fixes python-gdb.py, but I failed to fix test_gdb.py. With fast calls and patched python-gdb.py, python-gdb.py is now able to detect the Python frame of the call to the builtin id() function. It's a new feature compared to Python 3.5, but test_gdb.py should be updated to handle that.

    I will try to fix that later, but in the meanwhile I was interrupted because the fix for compact dict in python-gdb.py failed on buildbots, see:
    http://bugs.python.org/issue28023#msg281464

    @vstinner vstinner added the 3.7 (EOL) end of life label Nov 22, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 22, 2016

    New changeset 752863f96fb8 by Victor Stinner in branch 'default':
    Issue bpo-28770: Update python-gdb.py for fastcalls
    https://hg.python.org/cpython/rev/752863f96fb8

    @vstinner
    Copy link
    Member Author

    I keep the issue open until the 3.6 branch is reopened for regular bug fixes, like this one. Then I will backport the fix to 3.6.

    @methane
    Copy link
    Member

    methane commented Dec 7, 2016

    3.6 branch is reopened

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 8, 2016

    New changeset f41d02d7da37 by Victor Stinner in branch '3.6':
    Issue bpo-28770: Update python-gdb.py for fastcalls
    https://hg.python.org/cpython/rev/f41d02d7da37

    @vstinner
    Copy link
    Member Author

    vstinner commented Dec 8, 2016

    I fixed the issue in Python 3.6 (future 3.6.1).

    @vstinner vstinner closed this as completed Dec 8, 2016
    @ned-deily ned-deily reopened this Dec 16, 2016
    @vstinner
    Copy link
    Member Author

    The change was cherry-picked in Python 3.6.0RC2.

    The issue is now fixed, so I close the issue.

    @ned-deily
    Copy link
    Member

    Please leave this open until the cherry picking is completed.

    @ned-deily ned-deily reopened this Dec 16, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 17, 2016

    New changeset b0efa88c4cf4 by Victor Stinner in branch '3.6':
    Issue bpo-28770: Update python-gdb.py for fastcalls
    https://hg.python.org/cpython/rev/b0efa88c4cf4

    @ned-deily
    Copy link
    Member

    [cherrypicked for 3.6.0rc2]

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @methane @ned-deily