Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bdist_wininst generated 64-bit executable looks for 3.5-32 #72866

Closed
TimothyWidrick mannequin opened this issue Nov 13, 2016 · 5 comments
Closed

bdist_wininst generated 64-bit executable looks for 3.5-32 #72866

TimothyWidrick mannequin opened this issue Nov 13, 2016 · 5 comments
Assignees
@zooba
Labels
3.7 (EOL) end of life OS-windows stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@TimothyWidrick
Copy link
Mannequin

TimothyWidrick mannequin commented Nov 13, 2016

BPO 28680
Nosy @pfmoore, @tjguk, @merwok, @zware, @zooba, @dstufft
Superseder
  • bpo-26071: bdist_wininst created binaries fail to start and find 32bit Pythons
    		•
    Files
  • fix_issue28680.diff: Fix Issue28680
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2016-12-13.17:21:55.111>
created_at = <Date 2016-11-13.02:39:12.042>
labels = ['3.7', 'type-bug', 'library', 'OS-windows']
title = 'bdist_wininst generated 64-bit executable looks for 3.5-32'
updated_at = <Date 2016-12-13.17:21:55.109>
user = 'https://bugs.python.org/TimothyWidrick'

    bugs.python.org fields:

    activity = <Date 2016-12-13.17:21:55.109>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2016-12-13.17:21:55.111>
closer = 'steve.dower'
components = ['Distutils', 'Windows']
creation = <Date 2016-11-13.02:39:12.042>
creator = 'Timothy Widrick'
dependencies = []
files = ['45873']
hgrepos = []
issue_num = 28680
keywords = ['patch', '3.4regression']
message_count = 5.0
messages = ['280682', '283083', '283086', '283106', '283128']
nosy_count = 8.0
nosy_names = ['paul.moore', 'tim.golden', 'eric.araujo', 'cgohlke', 'zach.ware', 'steve.dower', 'dstufft', 'Timothy Widrick']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '26071'
type = 'behavior'
url = 'https://bugs.python.org/issue28680'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']
    @TimothyWidrick
    Copy link
    Mannequin Author

    TimothyWidrick mannequin commented Nov 13, 2016

    Short version: wininst-14.0-amd64.exe has "-32" in it. It shouldn't, should it?

    Longer version:

    Running "python setup.py bdist_wininst" gives me a file named like:

    project-version.win-amd64-py3.5.exe

    When I run that, I get:

    Python version 3.5-32 required, which was not found in the registry.

    My "fix" was to edit the wininst-14.0-amd64.exe and replace the "-32" with 3 null bytes.

    @TimothyWidrick TimothyWidrick mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Nov 13, 2016
    @cgohlke
    Copy link
    Mannequin

    cgohlke mannequin commented Dec 13, 2016

    Pillow-3.4.2.win-amd64-py3.5.exe fails to install due to this. See <https://github.com/python-pillow/Pillow/issues/2285\>.

    MS_WIN64 is never defined at https://hg.python.org/cpython/file/v3.5.2/PC/bdist_wininst/install.c#l157 because bdist_wininst does not depend on the Python headers. A possible fix is to use _WIN64 instead of MS_WIN64.

    @cgohlke
    Copy link
    Mannequin

    cgohlke mannequin commented Dec 13, 2016

    The attached patch was tested with Pillow-3.4.2 on Python 3.6.0rc1, 32-bit and 64-bit.

    It would be nice to get this fixed in Python 3.5.3 and 3.6.0.

    @cgohlke cgohlke mannequin added the OS-windows label Dec 13, 2016
    @zooba
    Copy link
    Member

    zooba commented Dec 13, 2016

    Thanks. 3.5.3 is definite, I've pinged the release manage on the original bug to see about 3.6.0, but definitely 3.6.1.

    Considering we've gone through all of 3.5 and 3.6 with very few people noticing (and as far as I'm aware, completely able to fix it themselves), it may not make the initial 3.6 release.

    @zooba zooba added the 3.7 (EOL) end of life label Dec 13, 2016
    @zooba zooba self-assigned this Dec 13, 2016
    @zooba
    Copy link
    Member

    zooba commented Dec 13, 2016

    Fixed for 3.5.3, 3.6.1 and default against the original bpo-26071

    @zooba zooba closed this as completed Dec 13, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.7 (EOL) end of life OS-windows stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @zooba