Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make objects with empty __slots__ GC types #72837

Open
1st1 opened this issue Nov 9, 2016 · 4 comments
Open

Make objects with empty __slots__ GC types #72837

1st1 opened this issue Nov 9, 2016 · 4 comments
Labels
3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@1st1
Copy link
Member

1st1 commented Nov 9, 2016

BPO 28651
Nosy @gvanrossum, @vstinner, @serhiy-storchaka, @1st1, @ilevkivskyi
Files
  • slots_gc.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2016-11-09.18:31:45.543>
labels = ['interpreter-core', '3.7']
title = 'Make objects with empty __slots__ GC types'
updated_at = <Date 2017-01-23.11:03:08.160>
user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2017-01-23.11:03:08.160>
actor = 'vstinner'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2016-11-09.18:31:45.543>
creator = 'yselivanov'
dependencies = []
files = ['45412']
hgrepos = []
issue_num = 28651
keywords = ['patch']
message_count = 4.0
messages = ['280427', '280435', '280445', '286072']
nosy_count = 5.0
nosy_names = ['gvanrossum', 'vstinner', 'serhiy.storchaka', 'yselivanov', 'levkivskyi']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue28651'
versions = ['Python 3.7']
    @1st1
    Copy link
    Member Author

    1st1 commented Nov 9, 2016

    The attached patch does the trick. I'm not sure if this should be fixed in 3.6.

    @1st1 1st1 added 3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Nov 9, 2016
    @serhiy-storchaka
    Copy link
    Member

    Needed tests. If an example with typing causes a leak (msg280422) this should be fixed in all versions that have typing.

    @1st1
    Copy link
    Member Author

    1st1 commented Nov 9, 2016

    So this patch has no impact on typing.py. Moreover, it's incomplete and fails test_gc tests, which can be fixed but not in 3.6.

    @vstinner
    Copy link
    Member

    This issue was mentioned in another issue when a refleak was found:

    http://bugs.python.org/issue24379#msg280456

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @1st1 @serhiy-storchaka