Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the cwd argument to subprocess.Popen accept a PathLike #72810

Closed
cool-RR mannequin opened this issue Nov 6, 2016 · 4 comments
Closed

Make the cwd argument to subprocess.Popen accept a PathLike #72810

cool-RR mannequin opened this issue Nov 6, 2016 · 4 comments
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@cool-RR
Copy link
Mannequin

cool-RR mannequin commented Nov 6, 2016

BPO 28624
Nosy @ncoghlan, @cool-RR, @berkerpeksag, @sayanchowdhury, @zhangyangyu
PRs
  • bpo-28624: Add test for subprocess to check that cmd arg supports PathLike #157
  • [3.6] bpo-28624: Add a test that checks that cwd parameter of Popen() accepts PathLike objects (#157) #323
  • fix subprocess on Windows (GH-391 backport) #623
  • [Do Not Merge] Sample of CPython life with blurb. #703
  • [Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-02-26.17:39:04.320>
created_at = <Date 2016-11-06.12:45:19.390>
labels = ['3.7', 'type-feature', 'library']
title = 'Make the `cwd` argument to `subprocess.Popen` accept a `PathLike`'
updated_at = <Date 2017-03-31.16:36:08.862>
user = 'https://github.com/cool-RR'

    bugs.python.org fields:

    activity = <Date 2017-03-31.16:36:08.862>
actor = 'dstufft'
assignee = 'none'
closed = True
closed_date = <Date 2017-02-26.17:39:04.320>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2016-11-06.12:45:19.390>
creator = 'cool-RR'
dependencies = []
files = []
hgrepos = []
issue_num = 28624
keywords = []
message_count = 4.0
messages = ['288074', '288605', '290377', '290378']
nosy_count = 5.0
nosy_names = ['ncoghlan', 'cool-RR', 'berker.peksag', 'sayanchowdhury', 'xiang.zhang']
pr_nums = ['157', '323', '623', '703', '552']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue28624'
versions = ['Python 3.6', 'Python 3.7']
    @cool-RR cool-RR mannequin added stdlib Python modules in the Lib dir 3.7 (EOL) end of life type-feature A feature request or enhancement labels Nov 6, 2016
    @sayanchowdhury
    Copy link
    Mannequin

    sayanchowdhury mannequin commented Feb 18, 2017

    I tested and found that the code already works with PathLike. I have created a PR which updates the test and documentation. I think the issue can be in Windows.

    @DimitrisJim DimitrisJim mannequin added tests Tests in the Lib/test dir and removed stdlib Python modules in the Lib dir labels Feb 18, 2017
    @berkerpeksag berkerpeksag added stdlib Python modules in the Lib dir and removed tests Tests in the Lib/test dir labels Feb 18, 2017
    @berkerpeksag
    Copy link
    Member

    Thanks for the patch, Sayan!

    @berkerpeksag
    Copy link
    Member

    New changeset 6b81003 by Berker Peksag in branch '3.6':
    bpo-28624: Add a test that checks that cwd parameter of Popen() accepts PathLike objects (#157) (#323)
    6b81003

    @berkerpeksag
    Copy link
    Member

    New changeset d5c11f7 by Berker Peksag (Sayan Chowdhury) in branch 'master':
    bpo-28624: Add a test that checks that cwd parameter of Popen() accepts PathLike objects (#157)
    d5c11f7

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @berkerpeksag