Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let shlex.quote accept a PathLike object #72809

Closed
cool-RR mannequin opened this issue Nov 6, 2016 · 3 comments
Closed

Let shlex.quote accept a PathLike object #72809

cool-RR mannequin opened this issue Nov 6, 2016 · 3 comments
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@cool-RR
Copy link
Mannequin

cool-RR mannequin commented Nov 6, 2016

BPO 28623
Nosy @bitdancer, @cool-RR, @berkerpeksag

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-11-07.17:28:40.305>
created_at = <Date 2016-11-06.09:44:36.391>
labels = ['3.7', 'type-feature', 'library']
title = 'Let `shlex.quote` accept a `PathLike` object'
updated_at = <Date 2016-11-07.17:28:40.303>
user = 'https://github.com/cool-RR'

bugs.python.org fields:

activity = <Date 2016-11-07.17:28:40.303>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2016-11-07.17:28:40.305>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2016-11-06.09:44:36.391>
creator = 'cool-RR'
dependencies = []
files = []
hgrepos = []
issue_num = 28623
keywords = []
message_count = 3.0
messages = ['280133', '280187', '280212']
nosy_count = 3.0
nosy_names = ['r.david.murray', 'cool-RR', 'berker.peksag']
pr_nums = []
priority = 'normal'
resolution = 'rejected'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue28623'
versions = ['Python 3.7']
@cool-RR
Copy link
Mannequin Author

cool-RR mannequin commented Nov 6, 2016

Currently it complains that you haven't fed it a string-like object.

@cool-RR cool-RR mannequin added 3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Nov 6, 2016
@bitdancer
Copy link
Member

Which IMO is correct. shlex.quote takes an arbitrary string, not a filename. I'm -1 on this proposal.

@berkerpeksag
Copy link
Member

Agreed with David. Closing this as 'rejected'. Thanks for the report.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@berkerpeksag @bitdancer