New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_typing fails if asyncio unavailable #72668
Comments
If you compile with “configure --without-threads”, various tests are already skipped because they rely on multithreading. However test_typing does not seem to handle this. It tries to import “asyncio”, which seems to depend on multithreading. I presume it is expected that asyncio requires multithreading, so perhaps the affected tests should be skipped in test_typing. Here is my attempt to skip them; please review. |
Can you submit this as a PR upstream, to github.com/python/typing? |
Ivan, if you want to apply it upstream be my guest! |
I will this to Git Hub when I get a chance to get set up, if that helps though :) |
Martin, I have opened a PR with your patch at python/typing |
New changeset c3363f684a2d by Guido van Rossum in branch '3.5': New changeset 8f3b4779afaf by Guido van Rossum in branch '3.6': New changeset c5fb5ac84f1e by Guido van Rossum in branch 'default': |
Martin can you verify that this worked? |
Yep, working well. Thanks Guido & Ivan. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: