Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interning string constants with null character #72536

Closed
serhiy-storchaka opened this issue Oct 3, 2016 · 6 comments
Closed

Interning string constants with null character #72536

serhiy-storchaka opened this issue Oct 3, 2016 · 6 comments
Assignees
@serhiy-storchaka
Labels
3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

BPO 28350
Nosy @brettcannon, @birkenfeld, @rhettinger, @ncoghlan, @vstinner, @benjaminp, @serhiy-storchaka, @1st1
PRs
  • [Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
    		•
    Files
  • all_name_chars.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2016-10-04.15:27:43.425>
created_at = <Date 2016-10-03.19:23:36.619>
labels = ['interpreter-core', 'type-bug', '3.7']
title = 'Interning string constants with null character'
updated_at = <Date 2017-03-31.16:36:09.847>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2017-03-31.16:36:09.847>
actor = 'dstufft'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2016-10-04.15:27:43.425>
closer = 'serhiy.storchaka'
components = ['Interpreter Core']
creation = <Date 2016-10-03.19:23:36.619>
creator = 'serhiy.storchaka'
dependencies = []
files = ['44945']
hgrepos = []
issue_num = 28350
keywords = ['patch']
message_count = 6.0
messages = ['277994', '277997', '278042', '278043', '278047', '278049']
nosy_count = 9.0
nosy_names = ['brett.cannon', 'georg.brandl', 'rhettinger', 'ncoghlan', 'vstinner', 'benjamin.peterson', 'python-dev', 'serhiy.storchaka', 'yselivanov']
pr_nums = ['552']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue28350'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6', 'Python 3.7']
    @serhiy-storchaka
    Copy link
    Member Author

    Currently string constants are interned if they consist of ASCII word characters ([0-9A-Za-z_]). But strings are tested only to the first null character. This is not problem for names, since they can't include null characters, but string constants that contains ASCII non-word characters after the null character passes this test.

    Proposed simple patch fixes the testing function all_name_chars().

    Other question: shouldn't PyUnicode_IsIdentifier() be used in 3.x?

    @serhiy-storchaka serhiy-storchaka added 3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Oct 3, 2016
    @vstinner
    Copy link
    Member

    vstinner commented Oct 3, 2016

    all_name_chars.patch LGTM.

    @serhiy-storchaka
    Copy link
    Member Author

    Thanks Victor.

    @serhiy-storchaka serhiy-storchaka self-assigned this Oct 4, 2016
    @vstinner
    Copy link
    Member

    vstinner commented Oct 4, 2016

    I have no opinion on interning non-ASCII strings.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 4, 2016

    New changeset 522adc2e082a by Serhiy Storchaka in branch '2.7':
    Issue bpo-28350: String constants with null character no longer interned.
    https://hg.python.org/cpython/rev/522adc2e082a

    New changeset d7ab3241aef2 by Serhiy Storchaka in branch '3.5':
    Issue bpo-28350: String constants with null character no longer interned.
    https://hg.python.org/cpython/rev/d7ab3241aef2

    New changeset 8585b4de4fc0 by Serhiy Storchaka in branch '3.6':
    Issue bpo-28350: String constants with null character no longer interned.
    https://hg.python.org/cpython/rev/8585b4de4fc0

    New changeset 563d523036c6 by Serhiy Storchaka in branch 'default':
    Issue bpo-28350: String constants with null character no longer interned.
    https://hg.python.org/cpython/rev/563d523036c6

    @serhiy-storchaka
    Copy link
    Member Author

    Added tests and refactored all_name_chars().

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @serhiy-storchaka