Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MacOS 9-specific module macurl2path.py #72512

Closed
yan12125 mannequin opened this issue Oct 1, 2016 · 4 comments
Closed

Remove MacOS 9-specific module macurl2path.py #72512

yan12125 mannequin opened this issue Oct 1, 2016 · 4 comments
Labels
3.7 (EOL) end of life OS-mac stdlib Python modules in the Lib dir

Comments

@yan12125
Copy link
Mannequin

yan12125 mannequin commented Oct 1, 2016

BPO 28325
Nosy @ronaldoussoren, @ned-deily, @yan12125
PRs
  • [Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-10-02.02:09:53.819>
created_at = <Date 2016-10-01.10:15:54.750>
labels = ['OS-mac', '3.7', 'library']
title = 'Remove MacOS 9-specific module macurl2path.py'
updated_at = <Date 2017-03-31.16:36:22.909>
user = 'https://github.com/yan12125'

    bugs.python.org fields:

    activity = <Date 2017-03-31.16:36:22.909>
actor = 'dstufft'
assignee = 'none'
closed = True
closed_date = <Date 2016-10-02.02:09:53.819>
closer = 'ned.deily'
components = ['Library (Lib)', 'macOS']
creation = <Date 2016-10-01.10:15:54.750>
creator = 'yan12125'
dependencies = []
files = []
hgrepos = []
issue_num = 28325
keywords = []
message_count = 4.0
messages = ['277805', '277842', '277843', '277850']
nosy_count = 4.0
nosy_names = ['ronaldoussoren', 'ned.deily', 'python-dev', 'yan12125']
pr_nums = ['552']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue28325'
versions = ['Python 3.7']
    @yan12125
    Copy link
    Mannequin Author

    yan12125 mannequin commented Oct 1, 2016

    As per PEP-11, MacOS 9 support is removed in Python 2.4. There are some leftovers in CPython code base, among which the macurl2path module is an example. I propose to remove it for cleaner codes.

    In f6785bce54b5 (bpo-7908), reference to macurl2path was removed from Lib/urllib.py, and macurl2path.py says:

    Do not import directly; use urllib instead.

    So, unlike the concern in bpo-9850, I bet there are no third party codes importing this module. It can be removed from CPython safely.

    Added some Mac experts.

    @yan12125 yan12125 mannequin added type-feature A feature request or enhancement 3.7 (EOL) end of life stdlib Python modules in the Lib dir OS-mac labels Oct 1, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 2, 2016

    New changeset 07c593845994 by Ned Deily in branch 'default':
    Issue bpo-28325: Remove vestigal MacOS 9 macurl2path module and its tests.
    https://hg.python.org/cpython/rev/07c593845994

    @ned-deily
    Copy link
    Member

    Thanks for the suggestion; I didn't even know that was still around. Because it is a bit late in the game for 3.6 and to be extra cautious, I decided to remove it starting with 3.7.

    @ned-deily ned-deily removed the type-feature A feature request or enhancement label Oct 2, 2016
    @yan12125
    Copy link
    Mannequin Author

    yan12125 mannequin commented Oct 2, 2016

    Thanks for landing all the changes :) It's definitely surprising to see those old CPython codes.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life OS-mac stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @ned-deily