Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade installers to OpenSSL 1.0.2j #72435

Closed
alex opened this issue Sep 22, 2016 · 13 comments
Closed

Upgrade installers to OpenSSL 1.0.2j #72435

alex opened this issue Sep 22, 2016 · 13 comments
Assignees
Labels
3.7 (EOL) end of life OS-mac OS-windows stdlib Python modules in the Lib dir topic-SSL type-security A security issue

Comments

@alex
Copy link
Member

alex commented Sep 22, 2016

BPO 28248
Nosy @pfmoore, @ronaldoussoren, @larryhastings, @tiran, @tjguk, @benjaminp, @ned-deily, @alex, @zware, @zooba, @dstufft, @matrixise, @scw, @Mariatta, @Safihre
PRs
  • [Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
  • [Security][3.4] bpo-29572: Update macOS installer build to OpenSSL 1.0.2k #3447
  • Files
  • issue28248.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ned-deily'
    closed_at = <Date 2016-11-01.00:02:53.494>
    created_at = <Date 2016-09-22.13:56:24.837>
    labels = ['type-security', 'OS-mac', 'expert-SSL', '3.7', 'library', 'OS-windows']
    title = 'Upgrade installers to OpenSSL 1.0.2j'
    updated_at = <Date 2017-09-08.02:35:37.158>
    user = 'https://github.com/alex'

    bugs.python.org fields:

    activity = <Date 2017-09-08.02:35:37.158>
    actor = 'vstinner'
    assignee = 'ned.deily'
    closed = True
    closed_date = <Date 2016-11-01.00:02:53.494>
    closer = 'ned.deily'
    components = ['Library (Lib)', 'macOS', 'Windows', 'SSL']
    creation = <Date 2016-09-22.13:56:24.837>
    creator = 'alex'
    dependencies = []
    files = ['45054']
    hgrepos = []
    issue_num = 28248
    keywords = ['patch', 'security_issue']
    message_count = 13.0
    messages = ['277226', '277234', '277410', '278448', '278453', '278454', '278859', '278866', '278867', '279842', '279843', '283004', '283028']
    nosy_count = 17.0
    nosy_names = ['paul.moore', 'ronaldoussoren', 'janssen', 'larry', 'christian.heimes', 'tim.golden', 'benjamin.peterson', 'ned.deily', 'alex', 'python-dev', 'zach.ware', 'steve.dower', 'dstufft', 'matrixise', 'scw', 'Mariatta', 'Safihre']
    pr_nums = ['552', '3447']
    priority = None
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'security'
    url = 'https://bugs.python.org/issue28248'
    versions = ['Python 2.7', 'Python 3.4', 'Python 3.5', 'Python 3.6', 'Python 3.7']

    @alex
    Copy link
    Member Author

    alex commented Sep 22, 2016

    @alex alex added 3.7 (EOL) end of life stdlib Python modules in the Lib dir topic-SSL labels Sep 22, 2016
    @tiran
    Copy link
    Member

    tiran commented Sep 22, 2016

    1.0.2i passes all tests of 2.7, 3.5-7 on Linux

    @tiran tiran removed their assignment Sep 22, 2016
    @tiran
    Copy link
    Member

    tiran commented Sep 26, 2016

    Make that OpenSSL 1.0.2j with fix for CVE-2016-7052

    https://www.openssl.org/news/openssl-1.0.2-notes.html

    @tiran tiran changed the title Upgrade installers to OpenSSL 1.0.2i Upgrade installers to OpenSSL 1.0.2j Sep 26, 2016
    @ned-deily
    Copy link
    Member

    We didn't get this into 3.6.0b2; needs to be in 3.6.0b3.

    @Mariatta
    Copy link
    Member

    Hi, I updated the openssl version from 1.0.2h to 1.0.2j in build-installer.py

    Please let me know if this works.

    Thanks :)

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 11, 2016

    New changeset c29045efd25e by Zachary Ware in branch '2.7':
    Issue bpo-28248: Update Windows build to use OpenSSL 1.0.2j
    https://hg.python.org/cpython/rev/c29045efd25e

    New changeset d7b9ce8ae79b by Zachary Ware in branch '3.4':
    Issue bpo-28248: Update Windows build to use OpenSSL 1.0.2j
    https://hg.python.org/cpython/rev/d7b9ce8ae79b

    New changeset 5fa74d8c987b by Zachary Ware in branch '3.5':
    Issue bpo-28248: Merge with 3.4
    https://hg.python.org/cpython/rev/5fa74d8c987b

    New changeset cc5006dab787 by Zachary Ware in branch '3.6':
    Issue bpo-28248: Merge with 3.5
    https://hg.python.org/cpython/rev/cc5006dab787

    New changeset fea9ff9e745d by Zachary Ware in branch 'default':
    Issue bpo-28248: Merge with 3.6
    https://hg.python.org/cpython/rev/fea9ff9e745d

    @matrixise
    Copy link
    Member

    @zach maybe we can close this issue if you have updated openssl ?

    @zware
    Copy link
    Member

    zware commented Oct 18, 2016

    The Mac installer still needs to be updated, which is Ned's department.

    @matrixise
    Copy link
    Member

    ok, thank you Zach for this comment.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 31, 2016

    New changeset 33ad26897e30 by Ned Deily in branch '2.7':
    Issue bpo-28248: Update macOS installer build to use OpenSSL 1.0.2j.
    https://hg.python.org/cpython/rev/33ad26897e30

    New changeset a8799a63feb7 by Ned Deily in branch '3.5':
    Issue bpo-28248: Update macOS installer build to use OpenSSL 1.0.2j.
    https://hg.python.org/cpython/rev/a8799a63feb7

    New changeset c7e551f8c5d8 by Ned Deily in branch '3.6':
    Issue bpo-28248: merge from 3.5
    https://hg.python.org/cpython/rev/c7e551f8c5d8

    New changeset 9e66ffa7a791 by Ned Deily in branch 'default':
    Issue bpo-28248: merge from 3.6
    https://hg.python.org/cpython/rev/9e66ffa7a791

    @ned-deily
    Copy link
    Member

    Thanks for the patch, Mariatta. Pushed for released in 2.7.13, 3.5.3, and 3.6.0b3.

    @Safihre
    Copy link
    Mannequin

    Safihre mannequin commented Dec 12, 2016

    From the changelog I interpreted this to mean that Python would now use OpenSSL 1.0.2j on macOS for it's ssl module.
    But this is not the case?
    On a fresh macOS Sierra VM I get:

    Python 2.7.13rc1 (v2.7.13rc1:4d6fd49eeb14, Dec  3 2016, 13:01:23) 
    [GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
    Type "help", "copyright", "credits" or "license" for more information.
    >>> import ssl
    >>> ssl.OPENSSL_VERSION
    'OpenSSL 0.9.8zh 14 Jan 2016'

    @ned-deily
    Copy link
    Member

    @s Safihre. See the ReadMe included with the python.org 2.7.x installers. (It is displayed at installation and a copy is installed to /Applications/Python 2.7/ReadMe.rtf) As explained there, for 2.7.13rc1 as in recent previous 2.7.x releases, only the 10.5+ installer variant is linked with the private copy of OpenSSL; the 10.6+ installer uses the Apple-supplied system version.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life OS-mac OS-windows stdlib Python modules in the Lib dir topic-SSL type-security A security issue
    Projects
    None yet
    Development

    No branches or pull requests

    6 participants