Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lzma does not support pathlib #72416

Closed
ethanfurman opened this issue Sep 21, 2016 · 4 comments
Closed

lzma does not support pathlib #72416

ethanfurman opened this issue Sep 21, 2016 · 4 comments
Assignees
@berkerpeksag
Labels
3.7 (EOL) end of life stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@ethanfurman
Copy link
Member

BPO 28229
Nosy @brettcannon, @ned-deily, @ethanfurman, @berkerpeksag, @serhiy-storchaka
PRs
  • [Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
    		•
    Files
  • open-lzma.stoneleaf.patch
  • issue28229_v2.diff
  • issue28229_v3.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/berkerpeksag'
closed_at = <Date 2016-10-04.17:39:50.353>
created_at = <Date 2016-09-21.07:30:51.085>
labels = ['3.7', 'type-bug', 'library']
title = 'lzma does not support pathlib'
updated_at = <Date 2017-03-31.16:36:17.948>
user = 'https://github.com/ethanfurman'

    bugs.python.org fields:

    activity = <Date 2017-03-31.16:36:17.948>
actor = 'dstufft'
assignee = 'berker.peksag'
closed = True
closed_date = <Date 2016-10-04.17:39:50.353>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2016-09-21.07:30:51.085>
creator = 'ethan.furman'
dependencies = []
files = ['44771', '44938', '44950']
hgrepos = []
issue_num = 28229
keywords = ['patch']
message_count = 4.0
messages = ['277904', '278014', '278019', '278067']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'ned.deily', 'ethan.furman', 'python-dev', 'berker.peksag', 'serhiy.storchaka']
pr_nums = ['552']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue28229'
versions = ['Python 3.6', 'Python 3.7']
    @ethanfurman ethanfurman added the type-bug An unexpected behavior, bug, or error label Sep 21, 2016
    @ned-deily ned-deily added the 3.7 (EOL) end of life label Sep 23, 2016
    @berkerpeksag
    Copy link
    Member

    Here's an updated patch that adds more tests and documentation changes.

    @berkerpeksag berkerpeksag added the stdlib Python modules in the Lib dir label Oct 2, 2016
    @berkerpeksag
    Copy link
    Member

    Attaching a new patch that addresses Serhiy's comments. Thanks!

    @serhiy-storchaka
    Copy link
    Member

    LGTM.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 4, 2016

    New changeset b512780c6589 by Berker Peksag in branch '3.6':
    Issue bpo-28229: lzma module now supports pathlib
    https://hg.python.org/cpython/rev/b512780c6589

    New changeset de398937653b by Berker Peksag in branch 'default':
    Issue bpo-28229: Merge from 3.6
    https://hg.python.org/cpython/rev/de398937653b

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @berkerpeksag berkerpeksag

    Labels
    3.7 (EOL) end of life stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @berkerpeksag @serhiy-storchaka @ned-deily @ethanfurman